Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining lock errors, fix remaining infinite requests timeouts, remove GuitarChords #1341

Merged
merged 19 commits into from
Dec 13, 2024

Conversation

C0rn3j
Copy link
Collaborator

@C0rn3j C0rn3j commented Dec 12, 2024

Fixes #1312 - get rid of the last remaining lock errors by simply checking all of the locked() states - we should really throw the exception block into a function later - it's repeated there like 10 times.

Fixes #1342 by removing the functionality and stashing most of it into a half-broken module.

Fixes all requests lacking timeouts, now they have minimum 10 or higher, as felt appropriate, can be changed later if it turns out problematic, this should hopefully resolve random lockups.

Renames tm to thread_manager and moves its definition to inside of the Tauon class.

Replaced some URLs which have a valid HTTPS redirect (or only allow HTTPS) for HTTPS.

Also very small cosmetic code fixups and typing.

Fixes run.sh crashing on Python not being found and gives a hint that the distro may simply be silly and package python2 under python, helps cases like #1325 (comment)

@C0rn3j C0rn3j changed the title Fix remaining lock errors, fix remaining infinite requests timeouts Fix remaining lock errors, fix remaining infinite requests timeouts, remove GuitarChords Dec 12, 2024
@Taiko2k Taiko2k merged commit 6bd3c6a into Taiko2k:master Dec 13, 2024
1 check passed
@C0rn3j C0rn3j deleted the localfix branch December 13, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guitarparty.com is dead Locks are being released even when already unlocked
2 participants