-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remaining lock errors, fix remaining infinite requests timeouts, remove GuitarChords #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move redundant check
…unctionality and stash it into a side module
C0rn3j
changed the title
Fix remaining lock errors, fix remaining infinite requests timeouts
Fix remaining lock errors, fix remaining infinite requests timeouts, remove GuitarChords
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1312 - get rid of the last remaining lock errors by simply checking all of the locked() states - we should really throw the exception block into a function later - it's repeated there like 10 times.
Fixes #1342 by removing the functionality and stashing most of it into a half-broken module.
Fixes all requests lacking timeouts, now they have minimum 10 or higher, as felt appropriate, can be changed later if it turns out problematic, this should hopefully resolve random lockups.
Renames
tm
tothread_manager
and moves its definition to inside of theTauon
class.Replaced some URLs which have a valid HTTPS redirect (or only allow HTTPS) for HTTPS.
Also very small cosmetic code fixups and typing.
Fixes
run.sh
crashing on Python not being found and gives a hint that the distro may simply be silly and package python2 under python, helps cases like #1325 (comment)