[WIP] repro hydrate() causes unhandled promise rejection with a throwing prefetchQuery
#7867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarlagerlof
changed the title
hydrate() causes unhandled promise rejection with a throwing prefetchQuery
|
@alvarlagerlof is this happening because of the Ideally, what we wanted to achieve is if the promise from the server fails, it would get retried on the client (since we pass it to the retryer). I'm wondering if adding a |
Yes the lack of
I realised the same about the retries. I tried adding Test log``` |
|
Not sure why it's "unhandled" then. The retryer does handle it 😅 - on the client |
I just tried this: // Note: `Promise.resolve` required cause
// RSC transformed promises are not thenable
const initialPromise = Promise.resolve(promise).then(deserializeData)
// this doesn't actually fetch - it just creates a retryer
// which will re-use the passed `initialPromise`
void query.fetch(undefined, { initialPromise }).catch(() => {
/* noop */
}It also resolved the unhandled promise rejection. So maybe something in the But the added sleep seems to cause a test fail regardless: Test log
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging an issue where I see
A query that was dehydrated as pending ended up rejecting. [${query?.queryHash}]: Error: server error; The error will be redacted in production buildslogged, but my SSR render also returned a status code of 500.Upon digging into the code, I think I found that
hydrate()can cause an unhandled promise rejection from here when dehydrateQuery catches an error and returns a Promise.reject because aqueryFnthrew.It seems like no tests are covering this, due to them ending before the rejection happens, but when I run the tests with the change in this PR, I get the following:
Test run
✔ nx run @tanstack/query-core:build [existing outputs match the cache, left as is] ✔ nx run @tanstack/query-persist-client-core:build [existing outputs match the cache, left as is] ✔ nx run @tanstack/react-query:build [existing outputs match the cache, left as is] ✔ nx run @tanstack/query-devtools:build [existing outputs match the cache, left as is] ✔ nx run @tanstack/react-query-persist-client:test:lib [existing outputs match the cache, left as is] ✔ nx run @tanstack/react-query-devtools:test:lib [existing outputs match the cache, left as is]———————————————————————————————————————————————————————————————————————————————————————————————————————————————————————
✖ nx run @tanstack/react-query:test:lib
> @tanstack/[email protected] test:lib /Users/alvar/Code/query/packages/react-query
> vitest --retry=3
———————————————————————————————————————————————————————————————————————————————————————————————————————————————————————
NX Ran target test:lib for 3 projects and 4 tasks they depend on (19s)
✔ 6/7 succeeded [6 read from cache]
✖ 1/7 targets failed, including the following:
View structured, searchable error logs at https://nx.app/runs/yruFhd2Ecu
ELIFECYCLE Command failed with exit code 1.