Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use base-orphans to make the GHC.Generics instances unconditional #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use base-orphans to make the GHC.Generics instances unconditional #13

wants to merge 1 commit into from

Conversation

Ericson2314
Copy link
Contributor

Fixes #8

@Ericson2314
Copy link
Contributor Author

It would be good to first merge

@Taneb
Copy link
Owner

Taneb commented Jan 2, 2022

My gut feeling is against this change, but I do have to admit it feels useful to have. Thanks for doing it in either case, I'll ruminate a bit on it.

@Ericson2314
Copy link
Contributor Author

Yeah I understand that. We did it by accident in patch, since we were getting the base orphans instances via `monoidal-containers unknowingly.

I wrote https://discourse.haskell.org/t/pre-hftp-decoupling-base-and-ghc/3727 for what I think ought to be the real solution, namely old GHCs just getting newer libraries with these instances.

@Ericson2314
Copy link
Contributor Author

(nothing urgent here, just rebasing out of fastidiousness.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use base-orphans to have fewer conditional instances?
2 participants
@Ericson2314 @Taneb