Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-uploads): Dropdown for filtering forms should contain form.title #3763

Closed

Conversation

evansdianga
Copy link
Contributor

Description


Add form.title to the label of the Dropdown and separate it and the form.id with triple dash

Type of Change

  • New feature (non-breaking change which adds functionality)

Proposed Solution


Add form.title to the label of the Dropdown and separate it and the form.id with triple dash

… title`

Add `form.title` to the label of the Dropdown and separate it and the `form.id` with triple dash

Refs #3751
@evansdianga evansdianga requested a review from esurface January 8, 2025 10:23
@evansdianga evansdianga changed the title feat(data-uploads): Dropdown for filtering forms should contain form title feat(data-uploads): Dropdown for filtering forms should contain form.title Jan 8, 2025
@esurface
Copy link
Contributor

esurface commented Jan 9, 2025

We need to handle cases where the form title includes t-lang tags for translations (see #3735).

Option 1:

  • Find and use the t-lang tag with 'en'
  • if no 'en', then use the first t-lang tag
  • If the form title is empty, use the form id

To Test:

  • Test with Arabic characters and Chinese characters

…ersion of the title or the first available language

When forms have `t-lang` tags, use the English version of the title. If the English version is not available, use the first available language.

Refs #3763
@evansdianga
Copy link
Contributor Author

evansdianga commented Jan 10, 2025

Added

  • If form.title is empty, use the form.id
  • When forms have t-lang tags, use the English version of the title. If the English version is not available, use the first available language.

@evansdianga
Copy link
Contributor Author

Closing this in favor of #3765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants