4.43.2-rc.3 allow prompt-for with now sound attribute in prompt-box

demo/tangy-radio-blocks-lists.html

@@ -120,6 +120,7 @@ <h3>tangy-radio-blocks lists demo</h3>
                                 <option value="instructions" label="prompt" play-on-open="on" sound="assets/sounds/letters_moving_windows_comp_help.mp3" image="./assets/images/instructions.png"></option>
                                 <option value="help" label="insturctions" prompt-for="moving_windows_comp_02" sound="assets/sounds/letters_moving_windows_comp_02_What_does_Kofi_like_to_do.mp3" image="./assets/images/ms-talk2.png"></option>
                                 <option value="hidden" label="hidden" prompt-for="moving_windows_comp_02" sound="assets/sounds/letters_moving_windows_comp_02_What_does_Kofi_like_to_do.mp3" image="./assets/images/ms-talk2.png" hidden></option>
+                                <option value="no-sound-prompt" label="hidden" prompt-for="moving_windows_comp_02" image="./assets/images/pig.png"></option>
                             </tangy-prompt-box>
                         </template>
                     </tangy-form-item>

input/tangy-radio-block.js

@@ -201,9 +201,7 @@ export class TangyRadioBlock extends TangyInputBase {
 
     if (this.shadowRoot.querySelector('img') != null) {
       this.shadowRoot.querySelector('img').addEventListener('click', (e) => {
-        if (this.sound !== '') {
           this.dispatchEvent(new CustomEvent('input-sound-triggered', { detail: {sound: this.sound, id: this.name, stopAndClearQueue: true} }))
-        }
       })
     }
 

package.json

@@ -1,7 +1,7 @@
 {
   "name": "tangy-form",
   "description": "A form element for lazy loaded multipage forms",
-  "version": "4.43.2-rc.2",
+  "version": "4.43.2-rc.3",
   "main": "tangy-form.js",
   "scripts": {
     "start": "polymer serve",

tangy-form-item.js

@@ -727,16 +727,13 @@ export class TangyFormItem extends PolymerElement {
       // add event listeners for clicks
       if (tangyPrompt.shadowRoot) {
         tangyPrompt.shadowRoot.querySelectorAll('tangy-radio-block').forEach((block) => {
+          const inputOptionName = `${tangyPrompt.name}-${block.name}`
+          block.addEventListener('input-sound-triggered', this.onInputSoundTriggered.bind(this, inputOptionName));
 
-          if (block.hasAttribute('sound') && block.getAttribute('sound') != '') {
-            const inputOptionName = `${tangyPrompt.name}-${block.name}`
-            block.addEventListener('input-sound-triggered', this.onInputSoundTriggered.bind(this, inputOptionName));
-
-            if (block.hasAttribute('play-on-open') && block.getAttribute('play-on-open') == "on") {
-              let inputOptionName = `${tangyPrompt.name}-${block.name}`
-              let playOnOpenEvent = new CustomEvent('input-sound-triggered', { detail: { sound: block.getAttribute('sound'), id: inputOptionName } } )
-              block.dispatchEvent(playOnOpenEvent)
-            }
+          if (block.hasAttribute('sound') && block.hasAttribute('play-on-open') && block.getAttribute('play-on-open') == "on") {
+            let inputOptionName = `${tangyPrompt.name}-${block.name}`
+            let playOnOpenEvent = new CustomEvent('input-sound-triggered', { detail: { sound: block.getAttribute('sound'), id: inputOptionName } } )
+            block.dispatchEvent(playOnOpenEvent)
           }
         })
       }
@@ -992,7 +989,9 @@ export class TangyFormItem extends PolymerElement {
       this.sectionPromptQueue.stopAndClearQueue();
     }
 
-    this.sectionPromptQueue.queue(input, event.detail.sound, eventName);
+    if (event.detail.sound) {
+      this.sectionPromptQueue.queue(input, event.detail.sound, eventName);
+    }
 
     if (input.hasAttribute("prompt-for") && input.getAttribute("prompt-for") != '') {
       let inputName = input.getAttribute("prompt-for")