Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to set custom layout #202

Merged
merged 7 commits into from
Oct 8, 2019

Conversation

minibugdev
Copy link
Contributor

Issue #88 #98

@kpmmmurphy
Copy link
Collaborator

Hey @minibugdev, thanks for this PR. Looking good to me. To finish it off, please update the version in the build.gradle - I think we should push it to a new major version: 5.0.0. Don't forget to update the changelog too! Thanks again.

@minibugdev
Copy link
Contributor Author

minibugdev commented Oct 7, 2019

Hi @kpmmmurphy, I bumped version to 5.0.0 and updated all documents.
Btw , should we merge PR #201 first coz its a minor changes on version 4.x.x

@kpmmmurphy
Copy link
Collaborator

Hey @minibugdev, that's brilliant. Yes, I think we should merge #201 first.

@kpmmmurphy kpmmmurphy merged commit b6c4ff2 into Tapadoo:develop Oct 8, 2019
@minibugdev minibugdev deleted the feature/set-custom-view branch October 8, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants