Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/v1.0 #2

Merged
merged 20 commits into from
Feb 20, 2024
Merged

Release/v1.0 #2

merged 20 commits into from
Feb 20, 2024

Conversation

tomshelllby
Copy link
Contributor

@tomshelllby tomshelllby commented Feb 20, 2024 •
edited
Loading

This PR updates:

  • The structure of the package to align better with package principles
  • Removes dependencies on dbt utils by making required macros native
  • Updates date spine model to add revenuecat prefix to avoid possible conflicts with native code
  • Adds primary keys (row IDs) to avoid need to combo column tests (less optimal)
  • Adds the license content
  • Adds basic CI

@tomshelllby tomshelllby requested a review from a team as a code owner February 20, 2024 12:26
jurrigerretsen
jurrigerretsen approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@jurrigerretsen jurrigerretsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomshelllby tomshelllby merged commit 982e56f into main Feb 20, 2024
1 check passed
@tomshelllby tomshelllby deleted the release/v1.0 branch February 20, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurrigerretsen jurrigerretsen jurrigerretsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomshelllby @jurrigerretsen