Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New fixes for compiling on newer Java versions #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Foxinatel
Copy link
Contributor

About a year ago I created a PR that introduced a small shim into the manifest and build script for fixing this project on newer versions of Java. Unfortunately this shim doesn't seem to properly work anymore, rendering it mostly ineffective.

This PR hopes to address these issues once again with a proper solution instead of a hacky workaround. The issue currently is with sun.awt.Mutex not being exported into the Java Runtime in newer versions.

Looking at the source code reveals that the only use of a sun.awt.Mutex is for mutual exclusion in some synchronized blocks. However Java allows you to synchronise over any type of object, so we can just change the type to Object to remove our dependency without changing any behaviour.

I have a release on my own fork tagged as 0.4.1, which was compiled with Java 8. I have additionally tested it against Java 17 and 21 and everything appears to work correctly.

@xavcochran
Copy link

would be great to get this merged, I'm having this issue on Mac with java 17 with v0.4! I am using your forked version for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants