Skip to content

Commit

Permalink
2.6.5 (#266)
Browse files Browse the repository at this point in the history
* Fix compile errors on ToAnyObservable for pre built framework

Compile seem not to like prebuilt frameworks with inferred genererics on that property wrapper
Added an error rule on swiftlint config to avoid non specifying the generics and risking it not building for carthage later

* Version 2.6.5
  • Loading branch information
Enricoza authored May 30, 2022
1 parent 6abb78a commit 3ed9f65
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 12 deletions.
10 changes: 5 additions & 5 deletions .swiftlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ number_separator:
large_tuple: 4

custom_rules:
rule_id:
included: Source/SwiftLintFramework/Rules/\w+\.swift
name: Rule ID
message: Rule IDs must be all lowercase, snake case and not end with `rule`
regex: identifier:\s*("\w+_rule"|"\S*[^a-z_]\S*")
any_observable_generics:
included: ./tealium
name: ToAnyObservable Generics
message: ToAnyObservable must always specify Generics type to avoid compile issues
regex: \@ToAnyObservable\s*\(
severity: error
2 changes: 1 addition & 1 deletion tealium-swift.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Pod::Spec.new do |s|

s.name = "tealium-swift"
s.module_name = "TealiumSwift"
s.version = "2.6.4"
s.version = "2.6.5"
s.summary = "Tealium Swift Integration Library"

# This description is used to generate tags and improve search results.
Expand Down
4 changes: 2 additions & 2 deletions tealium/collectors/autotracking/AutotrackingModule.swift
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import TealiumCore

public class AutotrackingModule: Collector {

@ToAnyObservable(TealiumBufferedSubject(bufferSize: 10))
@ToAnyObservable<TealiumBufferedSubject>(TealiumBufferedSubject(bufferSize: 10))
static var onAutoTrackView: TealiumObservable<String>

public let id: String = TealiumAutotrackingKey.moduleName
Expand All @@ -30,7 +30,7 @@ public class AutotrackingModule: Collector {
var blockList: [String]?
var blockListBundle = Bundle.main

@ToAnyObservable(TealiumReplaySubject())
@ToAnyObservable<TealiumReplaySubject>(TealiumReplaySubject())
private var onReady: TealiumObservable<Void>

/// Initializes the module
Expand Down
2 changes: 1 addition & 1 deletion tealium/collectors/location/TealiumLocationManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public class TealiumLocationManager: NSObject, CLLocationManagerDelegate, Tealiu
public var locationAccuracy: String = LocationKey.highAccuracy
private var _lastLocation: CLLocation?

@ToAnyObservable(TealiumReplaySubject())
@ToAnyObservable<TealiumReplaySubject>(TealiumReplaySubject())
var onReady: TealiumObservable<Void>

init(config: TealiumConfig,
Expand Down
2 changes: 1 addition & 1 deletion tealium/core/TealiumConstants.swift
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public enum Dispatchers {}

public enum TealiumValue {
public static let libraryName = "swift"
public static let libraryVersion = "2.6.4"
public static let libraryVersion = "2.6.5"
// This is the current limit for performance reasons. May be increased in future
public static let maxEventBatchSize = 10
public static let defaultMinimumDiskSpace: Int32 = 20_000_000
Expand Down
2 changes: 1 addition & 1 deletion tealium/core/TealiumInstanceManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public class TealiumInstanceManager {

public static var shared = TealiumInstanceManager()

@ToAnyObservable(TealiumReplaySubject(cacheSize: 10))
@ToAnyObservable<TealiumReplaySubject>(TealiumReplaySubject(cacheSize: 10))
var onOpenUrl: TealiumObservable<URL>

init() {
Expand Down
2 changes: 1 addition & 1 deletion tealium/core/appdata/AppDataModule.swift
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class AppDataModule: Collector {
private var bundle: Bundle
private var appDataCollector: AppDataCollection
var appData = AppData()
@ToAnyObservable(TealiumReplaySubject())
@ToAnyObservable<TealiumReplaySubject>(TealiumReplaySubject())
public var onVisitorId: TealiumObservable<String>

/// Retrieves current appdata
Expand Down

0 comments on commit 3ed9f65

Please sign in to comment.