fix: zoom (again) #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I kinda wanted Siro to look over this as well but oh well I guess it's not that big of a deal lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I randomly stumbled upon this open issue in the electron-toolkit repo and it's exactly about the zoom issue we're having lol alex8088/electron-toolkit#17. Apparently electron-toolkit just disables it by default (but not properly which is why it was so inconsistent between platforms for us).
That should hopefully fix
Ctrl+andCtrl-. However sinceCtrl=is also nice to have I've recreated the default Menu but with an additional invisible entry for theCommandOrControl+=accelerator (this is basically the way to do it until electron/electron#5256 has been implemented).