fix: 가상 계좌 취소 웹훅 오류 수정 #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byulcode
commented
Jan 13, 2024
Comment on lines
+106
to
107
| case CANCELED -> log.info("Virtual Amount Payment Canceled"); | ||
| default -> throw new BookingException(BookingErrorCode.INTERNAL_SERVER_ERROR); |
There was a problem hiding this comment.
cancelPayment 에서 상태값을 변경해주기 때문에 웹훅 전송시 별다른 동작이 필요 없다고 생각해 우선 로깅해놨습니다.!
annahxxl
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 기능
오류 상황 : 결제 수단이 가상 계좌일 때 결제 취소를 하면 서버 에러 발생
발생 이유: 가상계좌의 상태 변화는 아래와 같다. 즉, 결제 취소를 할 때에도 웹훅이 전송되는데, 그 때의 상태값
CANCELED에 대한 처리를 해주지 않아 예외가 발생했습니다.resolve: #242