⚡️: fix 코드리뷰 반영(!! to ?) #38

Team-Plu · Apr 14, 2024 · 40ea215 · 40ea215
1 parent ad00e46
commit 40ea215
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/plu-api/src/main/kotlin/com/th/plu/api/service/answer/AnswerService.kt b/plu-api/src/main/kotlin/com/th/plu/api/service/answer/AnswerService.kt
@@ -5,6 +5,7 @@ import com.th.plu.api.controller.answer.dto.response.EveryAnswerInfoResponse
 import com.th.plu.api.service.like.LikeValidator
 import com.th.plu.common.exception.code.ErrorCode
 import com.th.plu.common.exception.model.ConflictException
+import com.th.plu.common.exception.model.IllegalArgumentException
 import com.th.plu.domain.domain.answer.AnswerRegister
 import com.th.plu.domain.domain.answer.AnswerWriting
 import com.th.plu.domain.domain.answer.WritingAnswerResult
@@ -73,6 +74,7 @@ class AnswerService(
     fun findAllAnswerInfo(): EveryAnswerInfoResponse {
         val todayQuestion = questionExplorer.findTodayQuestion()
         val answerCount = answerRepository.findPublicAnswersCountByQuestionId(todayQuestion.id)
+            ?: throw IllegalArgumentException(ErrorCode.Illegal_ARGUMENT_ANSWER_COUNT_EXCEPTION, "answerCount는 비어 있을 수 없습니다.")
 
         return EveryAnswerInfoResponse.of(todayQuestion, answerCount)
     }

diff --git a/plu-common/src/main/kotlin/com/th/plu/common/exception/code/ErrorCode.kt b/plu-common/src/main/kotlin/com/th/plu/common/exception/code/ErrorCode.kt
@@ -49,4 +49,5 @@ enum class ErrorCode(val code: String, val message: String) {
 
     // Illegal Argument Exception
     Illegal_ARGUMENT_NICKNAME_EXCEPTION("IA001", "잘못된 닉네임 형식입니다."),
+    Illegal_ARGUMENT_ANSWER_COUNT_EXCEPTION("IA002", "answerCount는 비어있을 수 없습니다."),
 }
diff --git a/...main/src/main/kotlin/com/th/plu/domain/domain/answer/repository/AnswerRepositoryCustom.kt b/...main/src/main/kotlin/com/th/plu/domain/domain/answer/repository/AnswerRepositoryCustom.kt
@@ -10,7 +10,7 @@ interface AnswerRepositoryCustom {
 
     fun findEveryAnswersWithCursorAndPageSize(questionId: Long, lastAnswerId: Long, pageSize: Long): List<EveryAnswerRetrieveResponse>
 
-    fun findPublicAnswersCountByQuestionId(questionId: Long): Long
+    fun findPublicAnswersCountByQuestionId(questionId: Long): Long?
 
     fun findPublicAnswersLikeTopN(questionId: Long, getCount: Long): List<EveryAnswerRetrieveResponse>
 }