Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#102 video detail api #107

Merged
merged 13 commits into from
Jul 18, 2024
Merged

Conversation

Sangwook123
Copy link
Contributor

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • video detail, home api ์—ฐ๊ฒฐ

๐ŸŒฑ PR ํฌ์ธํŠธ

  • ๊ธฐ๋กํ•˜๊ธฐ, ์‚ญ์ œํ•˜๊ธฐ ์ œ์™ธ
  • ๋ถ๋งˆํฌ ์˜์ƒ์กฐํšŒ ๋ฏธ์™„
  • ๊ทธ ์™ธ ์•„์ง์•ˆ๋œ๋ถ€๋ถ„ ํ™•์ธ๋ถ€ํƒ ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

์Šคํฌ๋ฆฐ์ƒท
ํŒŒ์ผ์ฒจ๋ถ€๋ฐ”๋žŒ

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

Copy link
Contributor

@seohee0925 seohee0925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ƒˆ๋ฒฝ๊นŒ์ง€ ๋„˜ ๊ณ ์ƒ ๋งŽ์•˜์–ด์š” !!!!!!! ์ˆ˜์ •์‚ฌํ•ญ์€ ์—†์–ด๋ณด์ž…๋‹ˆ๋‹ค. ๐Ÿ‘

followerCount = if (originalIsFollowing) {
originalFollowerCount - 1
} else {
originalFollowerCount + 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํŒ”๋กœ์šฐ ๋ฒ„ํŠผ ๋ˆ„๋ฅด๊ณ  ๋ฐ”๋กœ count์— ๋ฐ˜์˜ํ•˜๋Š”๊ฑธ ์ƒ๊ฐ ๋ชปํ–ˆ๋Š”๋ฐ, ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค... ๐Ÿ‘

}
}
}
}

fun toggleFollow(user: Profile) {
fun toggleFollow() {
val originalIsFollowing = uiState.value.isFollowing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ฒ˜์Œ์— ํ”„๋กœํ•„ ๋“ค์–ด๊ฐ€๋ฉด ํŒ”๋กœ์šฐ ๋ฒ„ํŠผ์ด ๋ฐ˜์˜์ด ๋ฐ”๋กœ ์•ˆ ๋๋Š”๋ฐ state๋ฅผ ์ƒ๊ฐ ๋ชปํ–ˆ๋„ค์š”... ์ตœ๊ณ 

Comment on lines +92 to +103
}.mapCatching {
it.toCore()
}.recoverCatching { exception ->
when (exception) {
is HttpException -> {
throw ApiError(exception.message())
}

else -> {
throw exception
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—๋Ÿฌ ์ฒ˜๋ฆฌ ์‹œ mapCatching์ด๋ž‘ recoverCatching ๊ฐ™์€ ๊ฑด ๋ชป ๋ณด๋˜ ์ด๋ฒคํŠธ ์ฒ˜๋ฆฌ์ธ๋ฐ .. ํฅ๋ฏธ๋กญ๋„ค์š”๐Ÿ‘๐Ÿป ์„œ์น˜ํ•ด๋ณด๋‹ˆ ์ข‹์€ ์ฒ˜๋ฆฌ ๊ฐ™์•„ ์ €๋„ ์‡ฝ์ƒฅ ํ•ด๊ฐˆ๊ฒŒ์š” ใ…‹ใ…‹

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ €๋„ mapCating๊ตฌ๋ฌธ ์ž˜ ๋ชจ๋ฅด๋Š”๋ฐ ๋•๋ถ„์— ์ฐธ๊ณ ๊ฐ€ ๋์–ด์š”

Comment on lines +33 to +38
fun getVideos() {
getPreferenceKeywords()
getPopularVideos()
getRecentVideos()
}

Copy link
Contributor

@nagaeng nagaeng Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์›๋ž˜ init ์œผ๋กœ ๊ตฌํ˜„ํ•ด๋†“์œผ์…จ๋˜ ๊ฑด LaunchedEffect์—์„œ ์ฒ˜๋ฆฌํ•˜๋ ค๊ณ  ํ•จ์ˆ˜๋กœ ๋นผ์…จ๊ตฐ์š” !!!! ์ข‹์Šต๋‹ˆ๋‹ค ๐Ÿซก

Comment on lines +73 to +75
viewModel.fetchUserPreferences()
viewModel.fetchUserProfile()
viewModel.initialData()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜ค ์ €๋Š” LauncedEffect ๋ฐ–์—์„œ ์‚ฌ์šฉํ–ˆ๋Š”๋ฐ, ์ด๋ ‡๊ฒŒ ๋„ฃ์œผ๋‹ˆ ํ‚ค ๊ฐ’์ด ๋ณ€๊ฒฝ๋  ๋•Œ๋งŒ ํ˜ธ์ถœ๋˜๊ฒ ๋„ค์šค. ๐Ÿ‘๐Ÿป๐Ÿ‘๐Ÿป

Comment on lines +90 to +92
onDeleteClick: (Long) -> Unit,
onBookmarkClick: (Long) -> Unit,
onNicknameClick: (Long) -> Unit,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ใ…‹ใ…‹ ์ด๋Ÿฐ๊ฑฐ ํ•˜๋‚˜ ํƒ€์ž… ๋ฐ”๊พธ๋Š”๋ฐ ์—ด ๋ช‡๊ฐœ์”ฉ ์ˆ˜์ •ํ•ด์•ผ ํ•˜๋˜๋ฐ (์ € ํ•˜๋‚˜ ๊ณ ์น˜๋‹ค๊ฐ€ 30๋ถ„ ๋„˜๊ฒŒ ์ป๊ฑฐ๋ฉ์š”?) ........ ๊ณ ์ƒ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค ์ง„์งœ๋กœ

Copy link
Contributor

@nagaeng nagaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ์ง„์งœ ์ˆ˜๊ณ  ๋งŽ์•˜์–ด์š” ์šฐ์ฃผ์ตœ๊ฐ•์•ˆ๋“œ์ž๋ž‘ ์šฐ์ƒ์šฑํ”ผํ‹ฐ ๐Ÿ‘ฝ๐Ÿ’š

@Sangwook123 Sangwook123 merged commit c370415 into develop Jul 18, 2024
1 check passed
Copy link
Member

@cacaocoffee cacaocoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ง„์งœ ์ง„์งœ ์ˆ˜๊ณ ํ•˜์…จ์–ด์š”

@@ -6,6 +6,7 @@

<application
android:name=".RecordyApplication"
android:largeHeap="true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heap ํฌ๊ธฐ๊นŒ์ง€ ์‹ ๊ฒฝ์“ฐ๋‹ค๋‹ˆ..

Comment on lines +92 to +103
}.mapCatching {
it.toCore()
}.recoverCatching { exception ->
when (exception) {
is HttpException -> {
throw ApiError(exception.message())
}

else -> {
throw exception
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ €๋„ mapCating๊ตฌ๋ฌธ ์ž˜ ๋ชจ๋ฅด๋Š”๋ฐ ๋•๋ถ„์— ์ฐธ๊ณ ๊ฐ€ ๋์–ด์š”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] video detail api ์—ฐ๊ฒฐ
4 participants