-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#102 video detail api #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์๋ฒฝ๊น์ง ๋ ๊ณ ์ ๋ง์์ด์ !!!!!!! ์์ ์ฌํญ์ ์์ด๋ณด์
๋๋ค. ๐
followerCount = if (originalIsFollowing) { | ||
originalFollowerCount - 1 | ||
} else { | ||
originalFollowerCount + 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ํ๋ก์ฐ ๋ฒํผ ๋๋ฅด๊ณ ๋ฐ๋ก count์ ๋ฐ์ํ๋๊ฑธ ์๊ฐ ๋ชปํ๋๋ฐ, ๊ฐ์ฌํฉ๋๋ค... ๐
} | ||
} | ||
} | ||
} | ||
|
||
fun toggleFollow(user: Profile) { | ||
fun toggleFollow() { | ||
val originalIsFollowing = uiState.value.isFollowing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ฒ์์ ํ๋กํ ๋ค์ด๊ฐ๋ฉด ํ๋ก์ฐ ๋ฒํผ์ด ๋ฐ์์ด ๋ฐ๋ก ์ ๋๋๋ฐ state๋ฅผ ์๊ฐ ๋ชปํ๋ค์... ์ต๊ณ
}.mapCatching { | ||
it.toCore() | ||
}.recoverCatching { exception -> | ||
when (exception) { | ||
is HttpException -> { | ||
throw ApiError(exception.message()) | ||
} | ||
|
||
else -> { | ||
throw exception | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์๋ฌ ์ฒ๋ฆฌ ์ mapCatching์ด๋ recoverCatching ๊ฐ์ ๊ฑด ๋ชป ๋ณด๋ ์ด๋ฒคํธ ์ฒ๋ฆฌ์ธ๋ฐ .. ํฅ๋ฏธ๋กญ๋ค์๐๐ป ์์นํด๋ณด๋ ์ข์ ์ฒ๋ฆฌ ๊ฐ์ ์ ๋ ์ฝ์ฅ ํด๊ฐ๊ฒ์ ใ ใ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ ๋ mapCating๊ตฌ๋ฌธ ์ ๋ชจ๋ฅด๋๋ฐ ๋๋ถ์ ์ฐธ๊ณ ๊ฐ ๋์ด์
fun getVideos() { | ||
getPreferenceKeywords() | ||
getPopularVideos() | ||
getRecentVideos() | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์๋ init ์ผ๋ก ๊ตฌํํด๋์ผ์ จ๋ ๊ฑด LaunchedEffect์์ ์ฒ๋ฆฌํ๋ ค๊ณ ํจ์๋ก ๋นผ์ จ๊ตฐ์ !!!! ์ข์ต๋๋ค ๐ซก
viewModel.fetchUserPreferences() | ||
viewModel.fetchUserProfile() | ||
viewModel.initialData() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ค ์ ๋ LauncedEffect ๋ฐ์์ ์ฌ์ฉํ๋๋ฐ, ์ด๋ ๊ฒ ๋ฃ์ผ๋ ํค ๊ฐ์ด ๋ณ๊ฒฝ๋ ๋๋ง ํธ์ถ๋๊ฒ ๋ค์ค. ๐๐ป๐๐ป
onDeleteClick: (Long) -> Unit, | ||
onBookmarkClick: (Long) -> Unit, | ||
onNicknameClick: (Long) -> Unit, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ใ ใ ์ด๋ฐ๊ฑฐ ํ๋ ํ์ ๋ฐ๊พธ๋๋ฐ ์ด ๋ช๊ฐ์ฉ ์์ ํด์ผ ํ๋๋ฐ (์ ํ๋ ๊ณ ์น๋ค๊ฐ 30๋ถ ๋๊ฒ ์ป๊ฑฐ๋ฉ์?) ........ ๊ณ ์๋ง์ผ์ จ์ต๋๋ค ์ง์ง๋ก
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ์ง์ง ์๊ณ ๋ง์์ด์ ์ฐ์ฃผ์ต๊ฐ์๋์๋ ์ฐ์์ฑํผํฐ ๐ฝ๐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ง์ง ์ง์ง ์๊ณ ํ์ จ์ด์
@@ -6,6 +6,7 @@ | |||
|
|||
<application | |||
android:name=".RecordyApplication" | |||
android:largeHeap="true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heap ํฌ๊ธฐ๊น์ง ์ ๊ฒฝ์ฐ๋ค๋..
}.mapCatching { | ||
it.toCore() | ||
}.recoverCatching { exception -> | ||
when (exception) { | ||
is HttpException -> { | ||
throw ApiError(exception.message()) | ||
} | ||
|
||
else -> { | ||
throw exception | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ ๋ mapCating๊ตฌ๋ฌธ ์ ๋ชจ๋ฅด๋๋ฐ ๋๋ถ์ ์ฐธ๊ณ ๊ฐ ๋์ด์
๐ PR ์์ฝ
๐ฑ ์์ ํ ๋ด์ฉ
๐ฑ PR ํฌ์ธํธ
๐ธ ์คํฌ๋ฆฐ์ท
๐ฎ ๊ด๋ จ ์ด์