Feature/#130 search UI #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
검색 결과 있을 때 container
검색 중 화면
검색 결과 화면
seohee0925
requested review from
cacaocoffee,
lsakee,
nagaeng and
Sangwook123
키보드 여부에 따라서 변경
Sangwook123
requested changes
Oct 13, 2024
feature/search/src/main/java/com/record/search/SearchViewModel.kt
Outdated
Show resolved
Hide resolved
Sangwook123
requested changes
Oct 14, 2024
|
|
||
| data class SearchState( | ||
| val query: String = "", | ||
| val filteredItems: List<Exhibition> = emptyList(), |
There was a problem hiding this comment.
ImmutableList로 변경해주세요 ! compose 컴파일러는 List 타입을 Stable로 간주하지 않아서 불필요한 리컴포지션이 발생할 수 있습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR 요약
검색화면 UI 및 기능 구현
🌱 작업한 내용
🌱 PR 포인트
📸 스크린샷
Screen_Recording_20241011_042831.mp4
2024-10-11.101603.mp4
📮 관련 이슈