Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#72 others profile #78

Merged
merged 10 commits into from
Jul 15, 2024
Merged

Feature/#72 others profile #78

merged 10 commits into from
Jul 15, 2024

Conversation

seohee0925
Copy link
Contributor

@seohee0925 seohee0925 commented Jul 14, 2024 •
edited
Loading

๐Ÿ“Œ PR ์š”์•ฝ

์ƒ๋Œ€ ํ”„๋กœํ•„ ๋ทฐ ์ž‘์—…ํ–ˆ์Šต๋‹ˆ๋‹ค

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • ์ƒ๋Œ€ ํ”„๋กœํ•„ ๋ทฐ UI ์ž‘์—…ํ–ˆ์–ด์š”
  • typo emptyBold, body2Bold ์ถ”๊ฐ€ ํ–ˆ์Šต๋‹ˆ๋‹ค

๐ŸŒฑ PR ํฌ์ธํŠธ

  • video ์˜์กด์„ฑ ์ถ”๊ฐ€ ๋ถ€๋ถ„์€ ์ถ”ํ›„์— ์„œ๋ฒ„ ์—ฐ๊ฒฐ ํ›„ ์ œ๊ฑฐํ•  ์˜ˆ์ •์ž…๋‹ˆ๋‹ค.

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

@seohee0925 seohee0925 added ์Œˆ๋ฝ•ํ•œ UI ์„œํฌ ๐Ÿถ๐Ÿชฝ ์•ˆ๋…•ํ•˜์„ธ์š” ๋– ํฌ์ž…๋‹ˆ๋‹ค Skrrrrr~ labels Jul 14, 2024
@seohee0925 seohee0925 self-assigned this Jul 14, 2024
Sangwook123
Sangwook123 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@Sangwook123 Sangwook123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seohee0925 seohee0925 force-pushed the feature/#72-others-profile branch from 697a91e to e95504d Compare July 15, 2024 12:08
@seohee0925 seohee0925 merged commit 14d25b3 into develop Jul 15, 2024
1 check passed
@nagaeng nagaeng deleted the feature/#72-others-profile branch July 18, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sangwook123 Sangwook123 Sangwook123 approved these changes

@cacaocoffee cacaocoffee Awaiting requested review from cacaocoffee

@lsakee lsakee Awaiting requested review from lsakee

@nagaeng nagaeng Awaiting requested review from nagaeng

Assignees

@seohee0925 seohee0925

Labels
์„œํฌ ๐Ÿถ๐Ÿชฝ ์•ˆ๋…•ํ•˜์„ธ์š” ๋– ํฌ์ž…๋‹ˆ๋‹ค Skrrrrr~ ์Œˆ๋ฝ•ํ•œ UI
Projects
None yet
Milestone
UI ์ž‘์—… ๋ฐ ๊ธฐ๋Šฅ ๊ตฌํ˜„
Development

Successfully merging this pull request may close these issues.

[feat] other users profile
2 participants
@seohee0925 @Sangwook123