Write Curation View UI 변경사항 #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Release] Version 1.0.0
HanGyeongjun
requested review from
JIWON1923,
otoolz,
mxnxxii,
jim4020key and
JMM00
JMM00
approved these changes
Dec 1, 2022
Comment on lines
135
to
150
| Text("업로드") | ||
| .foregroundColor(.Text_Button) | ||
| .opacity(0.7) | ||
| Text("업로드") | ||
| .foregroundColor(.Primary) | ||
| .opacity(shortcut.color.isEmpty || | ||
| shortcut.sfSymbol.isEmpty || | ||
| shortcut.title.isEmpty || | ||
| !isNameValid || | ||
| shortcut.downloadLink.isEmpty || | ||
| !isLinkValid || | ||
| shortcut.subtitle.isEmpty || | ||
| !isOneLineValid || | ||
| shortcut.description.isEmpty || | ||
| !isMultiLineValid || | ||
| shortcut.category.isEmpty ? 0.3 : 1) |
There was a problem hiding this comment.
버튼에 스타일 적용이 안되어있네요..! 업로드는 Headline() 취소는 Body1()으로 적용 부탁드립니다!
JIWON1923
approved these changes
Dec 1, 2022
| } | ||
| } | ||
|
|
||
| //MARK: -단축어 사용 필요 앱 |
There was a problem hiding this comment.
이 부분 편집할 때 클릭이 안 돼요!
이슈 끊어서 추후에 작업이 필요할 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
구현/변경 사항
리뷰 시 참고해주세요.
스크린샷
작동 시 동영상 파일로 대체합니다.
Simulator.Screen.Recording.-.iPhone.14.-.2022-12-02.at.04.03.45.mp4