[FEATURE] 버전 관리 기능 추가 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
sanbonai06
reviewed
Nov 28, 2023
| @Builder | ||
| public class VersionInfoVo { | ||
|
|
||
| @Schema(description = "AOS 버전입니다.") |
There was a problem hiding this comment.
혹시 모르니 스키마 설명 바꿔주시면 좋겠어용
sanbonai06
reviewed
Nov 28, 2023
| import tify.server.domain.domains.AbstractTimeStamp; | ||
|
|
||
| @Getter | ||
| @Setter |
There was a problem hiding this comment.
setter말고 public 메서드로 업데이트 하는게 더 좋을 것 같아용
sanbonai06
reviewed
Nov 28, 2023
Comment on lines
24
to
34
| aosVersion.ifPresentOrElse( | ||
| version::setAosVersion, | ||
| () -> { | ||
| version.setAosVersion(recentVersion.getAosVersion()); | ||
| }); | ||
| iosVersion.ifPresentOrElse( | ||
| version::setIosVersion, | ||
| () -> { | ||
| version.setIosVersion(recentVersion.getIosVersion()); | ||
| }); | ||
| versionAdaptor.save(version); |
There was a problem hiding this comment.
각각 Optional로 검증하고 version.updateAosVersion으로만 하면 굳이 다시 save할 필요 없을 것 같아용
There was a problem hiding this comment.
이렇게 되면 Version 테이블에는 하나의 레코드만 있고 그걸 계속 변경하는 방식인가요?
There was a problem hiding this comment.
넵 그러면 굳이 limit1로 version entity를 끌어오는게 아니고 항상 하나만 조회 할 수 있기 때문에 더 좋은 것 같아용
sanbonai06
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR Summary
앱 버전 기능을 추가합니다
🌲 Working Branch
feat/113-app-version
🌲 TODOs
Related Issues
#113