[FEATURE] 특정 데일리 질문에 대한 친구들의 답변 몰아보기 API 작성 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanbonai06
reviewed
Nov 28, 2023
Comment on lines
+36
to
+43
| public static AnswerInfoVo from(Answer answer) { | ||
| return AnswerInfoVo.builder() | ||
| .id(Optional.ofNullable(answer).map(Answer::getId).orElse(null)) | ||
| .questionId(Optional.ofNullable(answer).map(Answer::getQuestionId).orElse(null)) | ||
| .userId(Optional.ofNullable(answer).map(Answer::getUserId).orElse(null)) | ||
| .content(Optional.ofNullable(answer).map(Answer::getContent).orElse(null)) | ||
| .build(); | ||
| } |
There was a problem hiding this comment.
이건 혹시 무슨일이 있었던 거죠?? answer가 없는데 조회 할 일이 있나요??
There was a problem hiding this comment.
내 친구들이 특정 데일리 질문에 답변하지 않았을 때 그 친구들은 answer가 null이기 때문입니닷
sanbonai06
reviewed
Nov 28, 2023
Comment on lines
+65
to
+77
| List<User> neighborList = | ||
| neighborAdaptor.queryAllByFromUserId(userId).stream() | ||
| .map(Neighbor::getToUserId) | ||
| .map(userAdaptor::query) | ||
| .toList(); | ||
| List<Long> blockedIdList = | ||
| userBlockAdaptor.queryAllByFromUserId(userId).stream() | ||
| .map(UserBlock::getToUserId) | ||
| .toList(); | ||
| List<Long> friendIdList = | ||
| neighborAdaptor.queryAllByFromUserId(userId).stream() | ||
| .map(Neighbor::getToUserId) | ||
| .toList(); |
There was a problem hiding this comment.
neighborList와 friendIdList가 다른게 뭐죠??
There was a problem hiding this comment.
neighborList는 User 객체 list고 friendIdList는 User pk list입니다
둘 중에 하나를 지울 수 있을 것 같기도 하네요...?!?!
sanbonai06
requested changes
Nov 28, 2023
sanbonai06
reviewed
Nov 29, 2023
Comment on lines
80
to
91
| Slice<RetrieveNeighborDTO> neighbors = | ||
| neighborAdaptor.searchNeighbors(neighborCondition, pageable); | ||
| List<NeighborAnswerInfoDTO> list = | ||
| neighbors.stream() | ||
| .map( | ||
| dto -> { | ||
| Optional<Answer> answer = | ||
| answerAdaptor.optionalQueryByQuestionAndUser( | ||
| questionId, dto.getNeighborId()); | ||
| return NeighborAnswerInfoDTO.builder() | ||
| .neighborInfo(dto) | ||
| .answerInfo(AnswerInfoVo.from(answer.orElse(null))) | ||
| .build(); | ||
| }) | ||
| .toList(); | ||
| return SliceResponse.of(SliceUtil.valueOf(list, pageable)); | ||
| List<RetrieveNeighborDTO> neighbors = neighborAdaptor.searchNeighbors(neighborCondition); | ||
| return neighbors.stream() | ||
| .map( | ||
| dto -> { | ||
| Optional<Answer> answer = | ||
| answerAdaptor.optionalQueryByQuestionAndUser( | ||
| questionId, dto.getNeighborId()); | ||
| return NeighborAnswerInfoDTO.builder() | ||
| .neighborInfo(dto) | ||
| .answerInfo(AnswerInfoVo.from(answer.orElse(null))) | ||
| .build(); | ||
| }) | ||
| .toList(); |
sanbonai06
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR Summary
특정 데일리 질문에 대한 친구들의 답변 몰아보기 API 작성
🌲 Working Branch
feat/112-neighbor-answer-list
🌲 TODOs
Related Issues
close #112