Feat/#195 auth user provider #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeongJongHo
requested review from
KimDonghyeok,
somarok,
hoogom88,
NalaJang and
gyubit
Closed
1 task
NalaJang
approved these changes
May 18, 2024
lib/main.dart
Outdated
| routerConfig: router, | ||
| ); | ||
| return Provider( | ||
| create: (context) => getIt<UserProvider>(), |
There was a problem hiding this comment.
그럼 유저 id 사용하려면 provider를 불러와서 사용하면 될까요?
There was a problem hiding this comment.
@NalaJang email만 사용 가능합니다!
somarok
reviewed
May 18, 2024
| buttonText: '둘러보기', | ||
| onPressedCheck: () => RouterStatic.goToHome(context), | ||
| buttonText: '확인', | ||
| onPressedCheck: () => RouterStatic.goToSignIn(context), |
There was a problem hiding this comment.
회원가입 후 로그인 화면으로 이동하나요? 바로 로그인 처리하는 걸로 알고있었는데..
There was a problem hiding this comment.
@somarok 리뷰 반영하여 수정했습니다
somarok
reviewed
May 18, 2024
hoogom88
reviewed
May 18, 2024
lib/main.dart
Outdated
| routerConfig: router, | ||
| ); | ||
| return Provider( | ||
| create: (context) => getIt<UserProvider>(), |
There was a problem hiding this comment.
router.dart에서 주입하도록 해서, 일괄적으로 provider를 관리할 수 있도록 하는게 나을 것 같습니다
There was a problem hiding this comment.
@hoogom88 리뷰 반영하여 수정했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:: 최근 작업 주제 (하나 이상의 주제를 선택해주세요.)
:: 구현 목표 (해당 브랜치에서 구현하고자 하는 하나의 목표를 설정합니다.)
:: 구현 사항 설명 (작업한 내용을 상세하게 기록합니다.)
:: 성장 포인트 (해당 기능을 구현하며 고민했던 사항이나 새로 알게된 부분, 어려웠던 점 등을 작성합니다.)
:: 기타 질문 및 특이 사항
관련된 로직중 디버깅이 들어가면서 코드 수정이 많이 되었습니다.
2_1. => user 프로퍼티 및 필드 추가