Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#227 apply firestore transaction #238

Merged
merged 19 commits into from
Jun 6, 2024

Conversation

KimDonghyeok
Copy link
Collaborator

@KimDonghyeok KimDonghyeok commented Jun 6, 2024

:: 최근 작업 주제 (하나 이상의 주제를 선택해주세요.)

  • 기능 추가
  • 리뷰 반영
  • 리팩토링
  • 버그 수정
  • 컨벤션 수정

:: 구현 목표 (해당 브랜치에서 구현하고자 하는 하나의 목표를 설정합니다.)

  • 원자성이 보장되어야 하는 비즈니스 로직에 트랜잭션 적용

:: 구현 사항 설명 (작업한 내용을 상세하게 기록합니다.)

  1. TransactionService 추상 클래스 작성
  2. TransactionService 구현체 TransactionService 클래스 작성
  3. OotdFeedRepositoryImplsaveOotdFeed(), removeOotdFeed() 트랜잭션 적용

:: 성장 포인트 (해당 기능을 구현하며 고민했던 사항이나 새로 알게된 부분, 어려웠던 점 등을 작성합니다.)

  • FireBase Store Api를 사용할 때 서로다른 collection을 사용한 동작에서 트랜잭션을 적용 가능한 방법을 고민하였다.

:: 기타 질문 및 특이 사항

@KimDonghyeok KimDonghyeok added ✨ Feature 기능 개발 🛠️ Refactor 리팩토링 [PR] 리뷰요청 리뷰 요청 드립니다. labels Jun 6, 2024
@KimDonghyeok KimDonghyeok linked an issue Jun 6, 2024 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@hoogom88 hoogom88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

Copy link
Collaborator

@NalaJang NalaJang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

Copy link
Collaborator

@SeongJongHo SeongJongHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

Copy link
Contributor

@somarok somarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@KimDonghyeok KimDonghyeok merged commit 1c51ce9 into dev Jun 6, 2024
2 checks passed
@KimDonghyeok KimDonghyeok deleted the feat/#227-apply-firestore-transaction branch June 6, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발 [PR] 리뷰요청 리뷰 요청 드립니다. 🛠️ Refactor 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataSource] Firestore 트랜잭션 처리
5 participants