Migrate video description and about channel fragments to Jetpack Compose #11489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
force-pushed
the
Video-description-compose
branch
from
7788a20
to
de6285b
Compare
github-actions
bot
added
size/giant
Isira-Seneviratne
force-pushed
the
Video-description-compose
branch
from
875e3fa
to
45aa445
Compare
Isira-Seneviratne
changed the title
Isira-Seneviratne
force-pushed
the
Video-description-compose
branch
from
954770b
to
387a4d5
Compare
AudricV
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Thank you! According to your what you provided, this finally fixes the scrolling issue when selecting text 🎉
In my opinion, the tag chips component isn't the right one. An ElevatedSuggestionChip or something similar would probably look a lot better and similar to the current one used in XML.
Like other metadata items and in the current design, the Tags text should be upper-case.
You should not talk about a video description but a stream description, there are audio-only supported services. So your new VideoDescriptionSection composable and its corresponding package should be renamed :)
| onTextLayout: (TextLayoutResult) -> Unit = {}, | ||
| style: TextStyle = LocalTextStyle.current | ||
| ) { | ||
| // TODO: Handle links and hashtags, Markdown. |
There was a problem hiding this comment.
This must be solved before the PR can be merged.
Isira-Seneviratne
force-pushed
the
Video-description-compose
branch
from
edf3782
to
8f9faf3
Compare
Isira-Seneviratne
force-pushed
the
Video-description-compose
branch
from
8d93272
to
0d12cfc
Compare
ShareASmile
added
rewrite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Before:
After:
Video:
Screen_recording_20240831_154300.mp4
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence