Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JJJoonngg
reviewed
Oct 10, 2023
| import dagger.hilt.android.HiltAndroidApp | ||
|
|
||
| @HiltAndroidApp | ||
| class OworiApplication: Application() { | ||
| override fun onCreate() { | ||
| super.onCreate() | ||
| KakaoSdk.init(this, "6c28960f69d4c7f00043b02d890dd6e0") |
There was a problem hiding this comment.
서버키 같은 상수들은 따로 strings.xml 이나 별도의 configuration.xml 로 관리하는게 좋을거 같습니다.
There was a problem hiding this comment.
별도의 configuration.xml에서 관리할 수 있도록 하겠습니다!
| import javax.inject.Inject | ||
|
|
||
| @HiltViewModel | ||
| class LoginViewModel @Inject constructor() : BaseViewModel() { | ||
| class LoginViewModel @Inject constructor(@ApplicationContext private val context: Context) : BaseViewModel() { |
There was a problem hiding this comment.
context를 주입받지 않고 그냥 AndroidViewModel을 사용해도 될 거 같습니다.
혹은 해당 context가 필요한 로직들은 activity에서 관장하고, 그 이후의 비즈니스 로직만 viewmodel에서 관리해도 될것으로 보입니다.
There was a problem hiding this comment.
넵 context 필요한 로직은 viewmodel에서 분리하겠습니다!
JJJoonngg
approved these changes
Oct 16, 2023
|
@bamin0422 conflit 해결해서 머지~! |
|
오케오케!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧨이슈
🔍 상세 내용 (해결 내용)
💡 참고자료 및 공유할만한 자료 (선택)
❕후속 진행 이슈