Project-business-site av Emelie Nyberg Kedert #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Hi Emelie, what a cool page you've created! The styling is very on point with the theme and your code is well structured.
HTML
- Nice usage of semantic elements, such as
headerandfooter⭐
CSS
- Your CSS maintains a consistent color scheme and typography, which gives your site a cohesive look and feel. The use of a background image with a gradient overlay looks so nice! I really like that you're reusing the orange color in all areas.
Clean Code
- Your CSS is well-organized, making it easy to follow and maintain.
- I really like that you reused the class name for the labels ⭐
- Make sure files and folders also uses kebab-case style when naming them.
Keep up the stellar work! 😉
Comment on lines
+21
to
+31
| With more time, I would focus on enhancing the user experience by adding more interactive elements and further refining the design. I would also explore the possibility of adding a validation to my password element saying "min 8 characters". One thing I couldn't achieve was using flexbox in mobile size to ensure that the list items in the <footer> were arranged with two items per row. In other words, I wanted it to look like this: | ||
|
|
||
| Product Contact us | ||
| Legal Language | ||
|
|
||
| and not: | ||
|
|
||
| Product Contact us Legal | ||
| Language | ||
|
|
||
| Maybe you have a suggestion how to solve this? :-D |
There was a problem hiding this comment.
Hmm, maybe you could play around with the `column-gap? property? 👀
|
I love this website Emelie!! The video gives such a nice vibe to it all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.