Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Estefanny Project week 3 business website #372

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
Binary file not shown.
13 changes: 8 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
# Business Site

Replace this readme with your own information about your project.

Start by briefly describing the assignment in a sentence or two. Keep it short and to the point.
we had to create a one page bussines website that contains a header, a Signup form and a submit button, the web site has to be styled and it must to be fully responsive

## The problem

Describe how you approached to problem, and what tools and techniques you used to solve it. How did you plan? What technologies did you use? If you had more time, what would be next?

The main problem for me was the form, style it was very tricky, and I had to research a lot using mostly chatgpt, w3school and stackoverflow. Despite I could mostly solve it, I'm still not 100% happy with it, because my main idea was to have an image horizontly in the left side and pairing it with the form to the right side. But when I was trying to add the image the form was losing its properties, at the end I decided to keep only the form, but I couldn't center it so I had to keep the form to the left side, leading an empty space in the right side of the website, if I had more time, I would want to fix this.

Another problem was upploading the hero video, I needed to increase the buffer size something I learned on stackoverflow.

## View it live
Every project should be deployed somewhere. Be sure to include the link to the deployed project so that the viewer can click around and see what it's all about.
Link to my business website

https://stirring-salamander-00e5a8.netlify.app/
Binary file added code/.DS_Store
Binary file not shown.
Binary file added code/images/.DS_Store
Binary file not shown.
Binary file added code/images/cincin.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added code/images/month-wine.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added code/images/next-events.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added code/images/our-wine.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added code/images/wine-me.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
81 changes: 77 additions & 4 deletions code/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,87 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Business Site</title>
<!-- dont forget to add a css file and link it here! -->
<link rel="stylesheet" href="./style.css" />
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.0.0-beta3/css/all.min.css">
</head>
<body>
<h1>Business name 🌻</h1>

<header>
<!--nav meny here -->
<nav>
<div class="logo-container">
<img src="./images/wine-me.png" alt="Logo Wine Me">
</div>

<!-- video or image as a header is cool :) -->
<ul>
<li><a href="#"><i class="fas fa-home"></i> Home</a></li>
<li><a href="#"><i class="fas fa-user"></i> Services</a></li>
<li><a href="#"><i class="fas fa-envelope"></i> Contact</a></li>
</ul>
</nav>
</header>

<!-- Signup form -->
<!---hero section-->
<div class="hero-container">
<!---Hero video-->
<video autoplay muted loop id="hero-video">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice video that works well on the deployed link and fits the theme perfect!

<source src="./video/wine-video.mp4" type="video/mp4">
</video>
<!--text over video-->
<div class="hero-text">
<h1>Your private wine collection</h1>
<p>Directly to your home</p>
<a href="#Signupform">
<button>Sign up</button>
</a>
</div>
</div>
<!--Images-->
<div class="image-gallery">
<img src="./images/our-wine.png" alt="our-wine" class="gray-image">
<img src="./images/month-wine.png" alt="month-wine">
<img src="./images/next-events.png" alt="events">
</div>

<!---illustration-->
<div class="illustration-container">
<img src="./images/cincin.png" alt="illustration">
</div>


<!-- Signup form -->



<form class="form-inline" action="https://httpbin.org/anything" method="post">
<div class="form-container" id="Signupform">
<h1>Create account</h1>
<p>Please fill in this form to create an account.</p>

<label for="name"><b>First Name</b></label>
<input type="text" placeholder="First Name" name="name" required>

<label for="LastName"><b>Last Name</b></label>
<input type="text" placeholder="Last Name" name="LastName" required>

<label for="email"><b>Email</b></label>
<input type="email" placeholder="Email" name="email" required>

<label>
<input type="checkbox" name="newsletter" style="margin-bottom: 15px;"> Sign me up for the newsletter
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it would be nice to have the same indentation as the other rows, it looks like "me up for the newsletter" is a bit outside the rest of the code. You probably have the space 2 indentation on and I'm not sure how to do it but something we can research for the future :)

</label>

<p>By creating an account you agree to our <a href="#" style="color: dodgerblue">term and conditions</a>.</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same thing I mentioned on row 74 I think could be applicable here as well.


<button type="submit" class="signupbtn">Create account</button>
</div>
</form>

<footer>
<div class="footer-content">
<p>&copy; 2024 Wine Me. All rights reserved.</p>
<p>Your go-to place for the finest wines.</p>
</div>
</footer>
</body>
</html>
276 changes: 275 additions & 1 deletion code/style.css
Original file line number Diff line number Diff line change
@@ -1,5 +1,279 @@
/* After you've linked the CSS file in the HTML,
this should turn the background blue ;) */
body {
background: blue;
background: rgb(246, 247, 231);
}

header {
display:block;
}

nav {
background-color: #FDFD7E;
overflow: hidden;
display: flex;
align-items: center;
justify-content: space-between;
padding: 10px;
border-bottom: 2px solid #ddd;
}

.logo-container {
margin-left: 40px;
display: flex;
align-items: center;
}

.logo-container img {
height: 50px; /* Ajusta la altura de la imagen según sea necesario */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see some of your comments are in spanish here. Maybe it's good to do them all in english :)

width: auto; /* Mantiene la proporción de la imagen */
}

nav ul {
list-style-type:none;
margin: 0%;
padding: 3;
display:flex;
color: rgb(246, 248, 248);
}

nav ul li {
float: right;
}

nav ul li a {
display: block;
color: #5358F6;
text-align: last;
padding: 20px 20px;
text-decoration: none;
}

nav ul li a:hover {
background-color: #ddd;

}

.hero-container {
position: relative;
width: 100%;
height: 100vh; /* 50% de la altura de la ventana gráfica */
overflow: hidden;
}

#hero-video {
position:absolute;
top: 50%;
left: 50%;
min-width: 100%;
min-height: 100%;
width: auto;
height: auto;
transform: translate(-50%, -50%); /* Centra el video */
z-index: -1; /* Envía el video al fondo */
}

.hero-text {
position: absolute;
top: 50%;
left: 50%;
transform: translate(-50%, -50%); /* Centra el texto */
text-align: center;
z-index: 1; /* Asegura que el texto esté por encima del video */
}

.hero-text h1 {
font-size: 48px;
margin: 0;
color: #FDFD7E;
}

.hero-text p {
font-size: 24px;
margin: 10px 0;
color: #ddd;
}

.hero-text button {
padding: 10px 20px;
font-size: 18px;
background-color: rgb(109, 106, 106) ; /* Color dorado para el botón */
border: none;
color: #FDFD7E;
cursor: pointer;
transition: background-color 0.3s ease;
}

.hero-text button:hover {
background-color: #d8d8d4; /* Color más oscuro al pasar el ratón */
}

/*images container*/

.image-gallery {
display: flex;
flex-wrap: wrap;
justify-content: center;
margin-top: 80px;
margin-bottom: 80px;
gap: 100px;
transition: .5s ease;
backface-visibility: hidden;
}

/*Default styles for larger screens*/
.image-gallery a:nth-child(3) {
flex: 1 1 1 100%; /*Default to 3 images per row*/
display: flex;
justify-content: center;
}


.image-gallery img {
border: 1px solid #ddd; /* Gray border */
border-radius: 4px; /* Rounded border */
padding: 5px; /* Some padding */
width: 300px; /* Set a small width */
}

/* Add a hover effect (blue shadow) */



.illustration-container {
width: 100%;
display: flex;
justify-content: center;
}


.illustration-container img {
width: 100%;
height: auto;
max-width: 1920px;
padding: 0%;
}

.form-inline {
display: flex;
flex-direction:row wrap;
align-items: center;
width: 50%;
}


input[type=text] , input[type=email]{
width: 90%;
padding: 10px;
margin: 5px 0px 22px 0px;
border: none;
background: #d8d8d4;
border-radius: 8px;
}

input[type=text]:focus , input[type=email]:focus {
background-color: #ddd;
outline: none;
}

button {
background-color:cornflowerblue;
color: white;
padding: 14px 20px;
margin: 8px 0;
border: none;
cursor: pointer;
width: 150px;
opacity: 1;
border-radius: 8px;
}

button:hover {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice with the hover effect here! I haven't used the this effect in my CSS yet but will definitely
take som inspiration from you here!

opacity: .6;
transition: .3s;
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some styling elements here I haven't tried before which sounds really interesting! Will try it out on my next project.

.form-container {
width: 50%;
flex-direction: column;
display:flex;
justify-content: center;
align-items:baseline;
padding: 5%;
background-color: #FDFD7E;
border-radius: 10px;
box-shadow: 0 4px 8px rgb(0, 0, 0, 0.1);
width: 90%;
margin: 50px auto;
margin-left: 50px;
font-family:Verdana, Geneva, Tahoma, sans-serif;
}


/*footer*/
footer {
background-color: #333;
color:#FDFD7E;
padding: 20px 0;
text-align: center;
font-family: Arial, sans-serif;
position: relative;
width: 100%;
bottom: 0;
}

.footer-content p {
margin: 5px 0;
font-size: 14px;
line-height: 1.6;
}

.footer-content {
max-width: 90%;
margin: auto;
}



Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried your media queries you've written here on your deployed site and it worked really well! Good job :)

/* Styles for mobile devices */

@media (min-width: 320px) and (max-width: 480px)
{
.image-gallery a {
flex: 1 1 1 100%;
}
}


@media (min-width: 481px) and (max-width: 768px)
{
.image-gallery a {
display: flex;
flex-wrap: wrap;
justify-content: center;
flex: 1 1 1 100%;

}
.form-inline input {
margin: 10px 0;
}

.form-inline {
flex-direction: column;
align-items: stretch;
}
/* Styles for tablets (iPad) */
}

@media (min-width: 769px) and (max-width: 1024px)
{
.image-gallery a {
flex: 1 1 1 100%;
}
}
/* Styles for regular screens (small laptops/desktops) */


@media (min-width: 1025px) {
/* Styles for large screens (large laptops/desktops) */
}
Binary file added code/video/wine-video.mp4
Binary file not shown.