-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit message for submodule changes #373
base: master
Are you sure you want to change the base?
Conversation
Please provide a Netlify link to your deployed site 👀 |
https://thekindeye.netlify.app/ This is the link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Brian! Nice job with your business site project 🐶 There are still some things to work out to meet all requirements - but first, some general feedback:
HTML
- Your form contains a variety of input types, such as text, email, date, and radio buttons and you've used the required attribute to enforce validation. Nice!
- Good labeling of your inputs!
- The tag ´
´is a bit out of date. Use CSS to create layout - Currently, the form's action is set to /submit-form, which won't work without a server. Please replace it with
https://httpbin.org/anything
for testing or local development. - The image is not really a hero image. Read more about hero images here.
CSS
- The color scheme is consistent throughout the page, with a soft blue background and a clean white form. Nice usage of box-shadow to create depth around the form 👍
- You need to take another look at the responsiveness of the page. The inputs are too wide for the form, and the image is cut off in mobile.
Changes Requested
- A header with responsive image/video
- The page should be fully responsive and work well on mobile as well as tablet and desktop (it should look good on devices from 320px width up to 1600px).
- Update form action so that we can test your form
Overall, this is a solid project! 🎉 With some minor adjustments you will meet the requirements. Reach out on Stack Overflow if you need any help ☎️
Hello I pushed change into my codes. |
Is it meeting the requierements now ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
Great job!
No description provided.