Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit message for submodule changes #373

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

smily342
Copy link

@smily342 smily342 commented Sep 1, 2024

No description provided.

@HIPPIEKICK
Copy link
Contributor

Please provide a Netlify link to your deployed site 👀

@smily342
Copy link
Author

smily342 commented Sep 3, 2024

https://thekindeye.netlify.app/

This is the link

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Brian! Nice job with your business site project 🐶 There are still some things to work out to meet all requirements - but first, some general feedback:

HTML

  • Your form contains a variety of input types, such as text, email, date, and radio buttons and you've used the required attribute to enforce validation. Nice!
  • Good labeling of your inputs!
  • The tag ´
    ´is a bit out of date. Use CSS to create layout
  • Currently, the form's action is set to /submit-form, which won't work without a server. Please replace it with https://httpbin.org/anything for testing or local development.
  • The image is not really a hero image. Read more about hero images here.

CSS

  • The color scheme is consistent throughout the page, with a soft blue background and a clean white form. Nice usage of box-shadow to create depth around the form 👍
  • You need to take another look at the responsiveness of the page. The inputs are too wide for the form, and the image is cut off in mobile.
    Skärmavbild 2024-09-04 kl  11 11 08

Changes Requested

  • A header with responsive image/video
  • The page should be fully responsive and work well on mobile as well as tablet and desktop (it should look good on devices from 320px width up to 1600px).
  • Update form action so that we can test your form

Overall, this is a solid project! 🎉 With some minor adjustments you will meet the requirements. Reach out on Stack Overflow if you need any help ☎️

@smily342
Copy link
Author

smily342 commented Sep 5, 2024

Hello I pushed change into my codes.
I updated the form action so my form can be tested anytime.
I try to change the header, with a "hero" setting from w3s but i still cannot have it take the whole page.
And my form should be more responsive.

@HIPPIEKICK
Copy link
Contributor

Hello I pushed change into my codes. I updated the form action so my form can be tested anytime. I try to change the header, with a "hero" setting from w3s but i still cannot have it take the whole page. And my form should be more responsive.

Do you have your deployment on Netlify set to continuous/automatic? Because it's still looking off for me:
Skärmavbild 2024-09-09 kl  10 39 46

Skärmavbild 2024-09-09 kl  10 40 04

@smily342
Copy link
Author

smily342 commented Oct 3, 2024

Is it meeting the requierements now ?

@JennieDalgren JennieDalgren self-assigned this Oct 8, 2024
Copy link
Contributor

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants