Xing Yin Business site version 1 #382
Conversation
xingyin2024
changed the title
|
@HIPPIEKICK I am not very clear about your comments, what should i change? Could you be more specific about which labels that is not proper or not right? Thanks! |
There was a problem hiding this comment.
The code overall is very well written and easy to follow and understand. The comments are informative and helps to understand the code and the using of space and indentation helps to easily follow the structure of the code. Consider using semantic HTML in some places for adding even more readability and also if it is possible to clean up the code a bit by removing the duplicates for example the navbar.
Good job :)
| <form action="http://httpbin.org/anything" method="post"> | ||
|
|
||
| <!-- Contact form only for smartphone--> | ||
| <div class="contact-form-for-small-screen"> |
There was a problem hiding this comment.
Consider using semantic HTML instead of for example using div to improve SEO and overall code readability.
| } */ | ||
|
|
||
| /* Style the video container and player to be centered and scale well */ |
There was a problem hiding this comment.
Well explained and nice to add specific comments which makes it easy to understand more specifically what the design does
| </div> | ||
|
|
||
| <!-- navbar container shall not show this time--> | ||
| <!-- <div class="navbar-menu-container"> |
There was a problem hiding this comment.
consider to not having two different navbars in the code to avoid that seems like a duplicate or maybe add more info in the comments of how its supposed to be used
| </label> | ||
| </div> | ||
| </div> | ||
| <!-- Style with flex box for checkbox input --> |
There was a problem hiding this comment.
good and informative comments when the style also is mentioned
code/index.html
Outdated
|
|
||
| <!-- Style of radio input --> | ||
| <span>I found you using</span><br> | ||
| <input type="radio" name="source" id="mouth" class="radio"><label for="mouth">Word of mouth</label><br> |
There was a problem hiding this comment.
consider using indentation for the inputs, for example
`
Hi again Xing! or by using the for/id attributes: I hope this clarifies what is required 😊 |
|
Hihi! @HIPPIEKICK |
http://xingspress.netlify.app