Xings book library #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… JS and button in html
HIPPIEKICK
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Great job on your project! Nice to see you played around with different features, like the favourite and the toggle 🥳
HTML/CSS
- Great use of CSS variables!
- Straight-forward HTML structure! Just remember that the nav element is used for navigation. Maybe a header element would make more sense?
JavaScript
- The getBooks function is well-defined and reusable - good job!
- Nice addition with the favourites and the reset button.
- However - the search bar is not connected to anything in the script? Remove unused code.
- Nice usage of the switch method!
Clean Code
- Good that you removed the files you're not using 👍
- Remember to be consistent with whether or not you're using semicolons! Don't mix!
Good job Xing, keep it up ⭐
Comment on lines
+31
to
+32
| <!-- Search input --> | ||
| <input type="text" id="searchInput" placeholder="Search by title..."> |
There was a problem hiding this comment.
This doesn't seem hooked up?
Comment on lines
+37
to
+44
| <!-- Hamburger menu for favorite books --> | ||
| <div class="hamburger-menu" onclick="toggleFavouriteMenu()"> | ||
| <div class="bar1"></div> | ||
| <div class="bar2"></div> | ||
| </div> | ||
|
|
||
| <nav id="favourites" class="hidden"> | ||
| <ul id="favouriteList">Choose your favorite books❤️</ul> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://xingsbooklibrary.netlify.app
Collaborators
solo