Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heléne - Project news site #522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Heleneabrahamsson
Copy link

@JennieDalgren JennieDalgren self-assigned this Aug 27, 2024
Copy link
Collaborator

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with your News Project!
Here are some feedback:

Responsive Typography and Images:

If you want to improve, even if we havent talked about this that much yet. Try to use relative units (like em, rem, or %) for font sizes and image widths rather than fixed px values. This ensures a smoother experience on various screen sizes.

Example:

h1 {
    font-size: 2rem; /* Scales better with screen size */
}
img {
    width: 100%; /* Makes images responsive */
}

HTML Structure:

Excellent choice of semantic elements like <header>, <main>, and <article>. One suggestion is to make sure that you have only one <h1> per page to maintain a clear hierarchy.

Example:
<h1>Main News Headline</h1> <!-- Keep only one h1 per page -->

Great work so far! Keep going, and these small tweaks will make your site even better. 👏

@Heleneabrahamsson Heleneabrahamsson changed the title Heléne - Added html and css to the news site project Heléne - Project news site Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants