Elina Eriksson Hult - Project News Site #527
Conversation
There was a problem hiding this comment.
Great job with this project 🎉
Excellent work using CSS Grid for the main article section and Flexbox for the header!
To explore: When defining your grid, try out repeat(auto-fit, minmax()) and see how that could help making the grid more flexible across screen sizes without needing many media queries.
You’ve added descriptive alt text to images, which is a great accessibility practice.
Suggestion: Ensure the alt text provides meaningful information, particularly for news images, by making them more descriptive of the image content.
The font choices and sizes are good for readability, especially on desktop. However, for mobile, consider slightly reducing the font size to fit the smaller viewport without overwhelming the user. Try using em or rem instead of px for fonts. (We havent talked much about this yet, but something to explore for the future)
Overall, this is a strong submission that effectively meets the project’s requirements! Great work, and keep refining these small details. 😊
Project news site