-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gabriella Iofe's Project News Site #531
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing netlify link and readme file
Corrected the requested changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with this project! You met all the requirements. ⭐
Your site is responsive and works well on mobile, tablet and desktop.
Nice to see that you have played around with some nice hover effects too.
Your code is easy to read and well strucutred.
Remember to use semantic elements, for example you are missing an <h1>
- which could be the heading of your site "Women who sent it". Make sure to style it as you want it to look. <h1>
and other elements serves a purpose outside the styling and looks. They are also used for SEO and accessibility reasons. (Read more in this cheat sheet )
Also make sure to change the link in the readme file to this one:
https://spectacular-entremet-5466db.netlify.app/
Keep up the good work!
Deployong a pull request into the Thechnigo repo. I hope... (first time) //Gaby