Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gabriella Iofe's Project News Site #531

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

gabster94
Copy link

Deployong a pull request into the Thechnigo repo. I hope... (first time) //Gaby

@gabster94 gabster94 closed this Aug 25, 2024
@gabster94 gabster94 reopened this Aug 25, 2024
@gabster94
Copy link
Author

@gabster94 gabster94 changed the title Main Gabriella Iofe's Project News Site Aug 29, 2024
@JennieDalgren JennieDalgren self-assigned this Aug 29, 2024
Copy link
Collaborator

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing netlify link and readme file

@gabster94
Copy link
Author

Corrected the requested changes :)

Copy link
Collaborator

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with this project! You met all the requirements. ⭐

Your site is responsive and works well on mobile, tablet and desktop.
Nice to see that you have played around with some nice hover effects too.

Your code is easy to read and well strucutred.
Remember to use semantic elements, for example you are missing an <h1> - which could be the heading of your site "Women who sent it". Make sure to style it as you want it to look. <h1> and other elements serves a purpose outside the styling and looks. They are also used for SEO and accessibility reasons. (Read more in this cheat sheet )

Also make sure to change the link in the readme file to this one:
https://spectacular-entremet-5466db.netlify.app/

Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants