Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mikas news site #535

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Mikas news site #535

wants to merge 8 commits into from

Conversation

mikaeber
Copy link

No description provided.

@JennieDalgren JennieDalgren self-assigned this Aug 29, 2024
Copy link
Collaborator

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with this project! Here are some comments on what you can improve or experiment with in the future.

Flex and Grid Usage:

The Flexbox implementation is well done. Your grid implementation for the news articles is solid. The layout is clean and adjusts well to different screen sizes.
Continue to explore: Try out the repeat() function in your grid template definitions to simplify your code and make it more readable.

General CSS Cleanliness:

Your CSS is mostly well-organized but you could take a look at consolidating some of your styles to avoid repetition, especially within your media queries.

When it comes to the design and layout, it is very nicely done and I like that you 've experimented with some fun hover effects. Remember to use a bit more of the screen when building the mobile view, no need for that much padding or margin on the sides. Use the screen size you have on smaller devices.

Keep up the good work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants