Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Portfolio #379

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Project Portfolio #379

wants to merge 13 commits into from

Conversation

Looziolooz
Copy link

AntonellaMorittu
AntonellaMorittu suggested changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@AntonellaMorittu AntonellaMorittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao Lorenzo, good job with your Portfolio. You're very close to the design and nailed the accessibility! The main requirements this week was to follow inch by inch the provided design, proportions, font-sizes, font alignments and colors (even with different values, follow the color pattern) on every screen size, mobile, tablet and desktop:

  • Are all font-sizes according to the design?
  • Are all sizes and distances (margin, padding) according to the design? Are the sections aligned where they should be?
  • Are the texts center/left aligned according to the design?

Main thing, make the buttons in the "Let's talk" section clickable, that's how the recruiter and employers are going to get in touch with you!

Almost there 🔥 You did really good 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonellaMorittu AntonellaMorittu AntonellaMorittu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Looziolooz @AntonellaMorittu