Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Week 12: Portfolio #399

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

jacquelinekellyhunt
Copy link

@jacquelinekellyhunt jacquelinekellyhunt commented Nov 4, 2024

@JennieDalgren JennieDalgren self-assigned this Nov 7, 2024
Copy link
Contributor

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with this project.
You're are almost there. Got through the design and really compare sizes and spacings and fonts thoroughly. Also it looks like you forgot the gitignore file, since your node modules got pushed to github. it means your project includes more than 5000 files.

image Here is an example on where your project differs too much from the design.

@jacquelinekellyhunt
Copy link
Author

@JennieDalgren thank you for pointing that out - I made some changes, and I hope this aligns with the requirements. Please let me know when anything else is necessary to change <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants