Xings Weather App #414
Open
Xings Weather App #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
previously requested changes
Oct 3, 2024
There was a problem hiding this comment.
HTML/CSS
- Well structured HTML, with semantic elements 👍
- Clean and organized CSS file as well with nice usage of CSS variables.
JavaScript
- Nice structure overall as well as well-named variables
- Impressive work with the stretch goal to show more cities!
- Nice error handling!
- One of the learning goals is understanding how to use JavaScript’s Date object. While you’ve fetched the current weather and the local time, it would make sense to display the local date and time for the searched location. I find it confusing that it's my local time for the cities that I know are in a different time zone than I am. This is true for both the Current Time and the sunset/sunrise times.
- Really good that you divided the code into modular functions, makes it more maintanable and easy to follow!
Changes Requested
- Fix the time bug (display the local sunset/sunrise and current times)
…ustedSunse by timezoneOffset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://xingsweatherapp.netlify.app/