[FIX] rma: fix split action read error. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Portal mail thread needs token config. - Unpublished products will raise AccessError on RMAs portal views for portal users due to record rules. - Set split window action domain to avoid context weird behavior
chienandalu
force-pushed
the
12.0-fix-rma_sale-portal
branch
2 times, most recently
from
a1ceec1 to
0429996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chienandalu , https://github.com/OCA/rma/pull/160/files#diff-9d0ebf28f17fe12f2501dd239c3f038cR32 doesn't seem to fix the error when splitting. When you access a Picking form to the linked RMA and then try to split, the error is thrown.
Apparently when the read method is called here https://github.com/OCA/rma/blob/12.0/rma/models/rma.py#L631, the value of the active_id key is not updated in context to put the ID of the rma, so I think we can force that value on it, what do you think?