Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVINGAPPS-10115 - Add living apps eslint config #22

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

soker90
Copy link
Member

@soker90 soker90 commented Jan 9, 2025

📌 Reference

Goal

  • Añadida librería de eslint de living apps
  • Aprovecho para actualizar dependencias (salvo react 19, funciona bien pero todavía no hemos actualizado en ninguna LA)

@soker90
Copy link
Member Author

soker90 commented Jan 9, 2025

@cbarroso @manuartero si no veis útil esta librería en el template me decís y cerramos la pr

src/mh-app.tsx Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esto no lo he quitado, pero lo mismo es hora no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cierto,

aunque es posible que renazca MH me ha comentado Carmen, en este repo si, fuego purificador 🔥

@soker90 soker90 requested review from manuartero and cbarroso January 9, 2025 15:37
@soker90 soker90 self-assigned this Jan 9, 2025
@manuartero
Copy link
Member

@cbarroso @manuartero si no veis útil esta librería en el template me decís y cerramos la pr

nono aquí es muy importante de hecho 🎇

Copy link
Member

@manuartero manuartero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

si puedes quitar los ^ asi que veas faciles dale

.nvmrc Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

.prettierrc.mjs Outdated

const prettierConfig = yaml.load(prettierFile);

export default prettierConfig;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

que curioso que no pite el linter aquí (no hay linea en blanco al final del fichero), podría ser por qué es .mjs @soker90 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pues sí, es justo eso, añado mjs

"prettier:write": "prettier --write '**/*.{js,ts,tsx,json,md,css,sass,scss}'",

package.json Outdated
Comment on lines 31 to 39
"@telefonica/living-apps-eslint-config": "0.1.2",
"@testing-library/jest-dom": "^6.6.3",
"@testing-library/react": "^16.1.0",
"@types/jest": "^29.5.14",
"@types/react": "^19.0.4",
"@types/react-dom": "^19.0.2",
"@vitejs/plugin-legacy": "^6.0.0",
"@vitejs/plugin-react-swc": "^3.7.2",
"eslint": "^8.57.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya que tocamos aquí, pon porfa las exactas (sin ^) 🙏

src/index.tsx Outdated
Comment on lines 17 to 21
<React.StrictMode>
<StrictMode>
<App />
</React.StrictMode>,
</StrictMode>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@soker90 soker90 merged commit 1beed13 into master Jan 10, 2025
@soker90 soker90 deleted the add-eslint-lib branch January 10, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants