-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIVINGAPPS-10115 - Add living apps eslint config #22
Conversation
@cbarroso @manuartero si no veis útil esta librería en el template me decís y cerramos la pr |
src/mh-app.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Esto no lo he quitado, pero lo mismo es hora no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cierto,
aunque es posible que renazca MH me ha comentado Carmen, en este repo si, fuego purificador 🔥
nono aquí es muy importante de hecho 🎇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
si puedes quitar los ^
asi que veas faciles dale
.nvmrc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool
.prettierrc.mjs
Outdated
|
||
const prettierConfig = yaml.load(prettierFile); | ||
|
||
export default prettierConfig; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
que curioso que no pite el linter aquí (no hay linea en blanco al final del fichero), podría ser por qué es .mjs
@soker90 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pues sí, es justo eso, añado mjs
"prettier:write": "prettier --write '**/*.{js,ts,tsx,json,md,css,sass,scss}'",
package.json
Outdated
"@telefonica/living-apps-eslint-config": "0.1.2", | ||
"@testing-library/jest-dom": "^6.6.3", | ||
"@testing-library/react": "^16.1.0", | ||
"@types/jest": "^29.5.14", | ||
"@types/react": "^19.0.4", | ||
"@types/react-dom": "^19.0.2", | ||
"@vitejs/plugin-legacy": "^6.0.0", | ||
"@vitejs/plugin-react-swc": "^3.7.2", | ||
"eslint": "^8.57.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya que tocamos aquí, pon porfa las exactas (sin ^
) 🙏
src/index.tsx
Outdated
<React.StrictMode> | ||
<StrictMode> | ||
<App /> | ||
</React.StrictMode>, | ||
</StrictMode>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗
📌 Reference
Goal