add icon keywords file #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnaMontes11
reviewed
Sep 7, 2023
| 4. Create an issue [here](https://github.com/Telefonica/mistica-design/issues/new?assignees=&labels=fundamentals%3A+icons%2Crequest+%E2%9C%A8&template=icon_request.yml&title=Title) | ||
| 5. That's all! We will review If your icon have all the needs to add it to mistica-icons | ||
| 4. Provide 3 synonyms for this icon. [Keywords file](icons/icons-keywords.json) | ||
| 5. Create an issue [here](https://github.com/Telefonica/mistica-design/issues/new?assignees=&labels=fundamentals%3A+icons%2Crequest+%E2%9C%A8&template=icon_request.yml&title=Title) |
There was a problem hiding this comment.
Dentro de la propia issue metería un apartado que sea "Provide 3 synonyms for this icon"
There was a problem hiding this comment.
uuu nice. Lo añado.
Molaría que al añadir un nuevo icono fuese todo automatico, que se añadiera solo al json de keywords y con IA incluyese los sinonimos en todos los idiomas ✨
There was a problem hiding this comment.
Añadido a la template de las issues para icon request
Telefonica/mistica-design#1459
yceballost
commented
Sep 18, 2023
There was a problem hiding this comment.
añadí instrucciones dentro del script, es "algo dificil".. pero bueno.. intentaremos facilitarlo en el futuro para que sea más friendly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new file called "icons-keywords.json" and makes changes to the ".prettierrc" file.
The "icons-keywords.json" file includes a list of keywords associated with different icons in our project. These keywords will help improve the searchability and organization of our icons, making it easier for developers to find the icons they need.
The ".prettierrc" file change updates the "printWidth" property to 1000, which will allow for better formatting and readability of our code.
Overall, these changes improve the project by enhancing the usability and maintainability of our icon system and improving the code formatting.