Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for keywords #280

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Test for keywords #280

merged 1 commit into from
Oct 15, 2023

Conversation

yceballost
Copy link
Collaborator

@yceballost yceballost commented Oct 15, 2023

Adds a new workflow to check for keywords in our icon files. It is important to ensure that all icons have corresponding keywords in our JSON file, as this helps with searchability and organization within our project.

The workflow is triggered on pull requests targeting the production branch, and it runs whenever changes are made to files in the "icons" directory. The workflow performs the following steps:

  1. Lists all SVG files in the "icons" directory and extracts their filenames.
  2. Reads the JSON file containing the keywords for the icons.
  3. Extracts the keywords from the JSON file and saves them in a separate file.
  4. Compares the icon filenames with the keywords in the JSON file and checks for any missing icons.
  5. Cleans up temporary files created during the process.

By adding this workflow, we can ensure that all icons have associated keywords, which improves the organization and searchability of our project.

@yceballost yceballost marked this pull request as ready for review October 15, 2023 01:33
@yceballost yceballost merged commit 15c74d6 into production Oct 15, 2023
1 check passed
@yceballost yceballost deleted the keywords-checks branch October 15, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant