-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(Icons): use icon keywords from mistica design in catalog story (#…
…914) * checkout icon keywords from mistica design * fix bugs and update story/screenshot test * fix pascal case
- Loading branch information
1 parent
25ed4eb
commit 286e385
Showing
22 changed files
with
3,216 additions
and
109 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file removed
BIN
-1.04 MB
...__image_snapshots__/icons-screenshot-test-tsx-icons-catalog-for-blau-1-snap.png
Binary file not shown.
Binary file removed
BIN
-1.13 MB
...__image_snapshots__/icons-screenshot-test-tsx-icons-catalog-for-blau-2-snap.png
Binary file not shown.
Binary file removed
BIN
-985 KB
...__image_snapshots__/icons-screenshot-test-tsx-icons-catalog-for-blau-3-snap.png
Binary file not shown.
Binary file added
BIN
+904 KB
..._snapshots__/icons-screenshot-test-tsx-icons-catalog-for-blau-filled-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+957 KB
...e_snapshots__/icons-screenshot-test-tsx-icons-catalog-for-blau-light-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.02 MB
...snapshots__/icons-screenshot-test-tsx-icons-catalog-for-blau-regular-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-1.04 MB
...age_snapshots__/icons-screenshot-test-tsx-icons-catalog-for-movistar-1-snap.png
Binary file not shown.
Binary file removed
BIN
-1.13 MB
...age_snapshots__/icons-screenshot-test-tsx-icons-catalog-for-movistar-2-snap.png
Binary file not shown.
Binary file removed
BIN
-985 KB
...age_snapshots__/icons-screenshot-test-tsx-icons-catalog-for-movistar-3-snap.png
Binary file not shown.
Binary file added
BIN
+970 KB
...pshots__/icons-screenshot-test-tsx-icons-catalog-for-movistar-filled-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.02 MB
...apshots__/icons-screenshot-test-tsx-icons-catalog-for-movistar-light-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.11 MB
...shots__/icons-screenshot-test-tsx-icons-catalog-for-movistar-regular-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-1.04 MB
.../__image_snapshots__/icons-screenshot-test-tsx-icons-catalog-for-o-2-1-snap.png
Binary file not shown.
Binary file removed
BIN
-1.13 MB
.../__image_snapshots__/icons-screenshot-test-tsx-icons-catalog-for-o-2-2-snap.png
Binary file not shown.
Binary file removed
BIN
-985 KB
.../__image_snapshots__/icons-screenshot-test-tsx-icons-catalog-for-o-2-3-snap.png
Binary file not shown.
Binary file added
BIN
+968 KB
...e_snapshots__/icons-screenshot-test-tsx-icons-catalog-for-o-2-filled-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.01 MB
...ge_snapshots__/icons-screenshot-test-tsx-icons-catalog-for-o-2-light-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.1 MB
..._snapshots__/icons-screenshot-test-tsx-icons-catalog-for-o-2-regular-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,34 +1,26 @@ | ||
import {openStoryPage, screen} from '../test-utils'; | ||
import {openStoryPage} from '../test-utils'; | ||
|
||
const SKINS = ['Movistar', 'O2', 'Blau'] as const; | ||
|
||
test.each(SKINS)('Icons catalog for %s', async ([skin]) => { | ||
const ICON_TYPES = ['light', 'regular', 'filled']; | ||
|
||
const getCases = () => { | ||
const cases = []; | ||
for (const skin of SKINS) { | ||
for (const type of ICON_TYPES) { | ||
cases.push([skin, type]); | ||
} | ||
} | ||
return cases; | ||
}; | ||
|
||
test.each(getCases())('Icons catalog for %s (%s)', async (skin, type) => { | ||
const page = await openStoryPage({ | ||
id: 'icons-catalog--catalog', | ||
device: 'DESKTOP', | ||
skin: skin as (typeof SKINS)[number], | ||
args: {light: type === 'light', regular: type === 'regular', filled: type === 'filled'}, | ||
}); | ||
|
||
const lightCheckbox = await screen.findByLabelText('Light'); | ||
const filledCheckbox = await screen.findByLabelText('Filled'); | ||
const regularCheckbox = await screen.findByLabelText('Regular'); | ||
// initially all checkboxes are checked | ||
|
||
await filledCheckbox.click(); | ||
await regularCheckbox.click(); | ||
|
||
const light = await page.screenshot({fullPage: true}); | ||
expect(light).toMatchImageSnapshot(); | ||
|
||
await lightCheckbox.click(); | ||
await regularCheckbox.click(); | ||
|
||
const regular = await page.screenshot({fullPage: true}); | ||
expect(regular).toMatchImageSnapshot(); | ||
|
||
await regularCheckbox.click(); | ||
await filledCheckbox.click(); | ||
|
||
const filled = await page.screenshot({fullPage: true}); | ||
expect(filled).toMatchImageSnapshot(); | ||
const icons = await page.screenshot({fullPage: true}); | ||
expect(icons).toMatchImageSnapshot(); | ||
}); |
Oops, something went wrong.
286e385
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for mistica-web ready!
✅ Preview
https://mistica-oemj16feg-tuentisre.vercel.app
Built with commit 286e385.
This pull request is being automatically deployed with vercel-action