feat(FeedbackScreens): updates in icons, paddings and styling #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
marcoskolodny
commented
Aug 11, 2023
•
marcoskolodny
commented
- Fix margins in mobile
- Update icon size for every screen
- Allow custom icon for InfoFeedbackScreen (https://jira.tid.es/browse/WEB-742)
- Extra slot: deprecate children and use extra prop
- New icon in SuccessFeedbackScreen for VIVO_NEW skin (https://jira.tid.es/browse/WEB-1504)
- Cascading opacity effect for Screen Content (title/description/extra)
|
Size stats
|
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 26c07a2. |
|
Accessibility report ℹ️ You can run this locally by executing |
marcoskolodny
requested review from
pladaria,
AnaMontes11,
yceballost and
aweell
and removed request for
AnaMontes11
pladaria
reviewed
Aug 16, 2023
pladaria
reviewed
Aug 16, 2023
pladaria
reviewed
Aug 16, 2023
pladaria
reviewed
Aug 16, 2023
pladaria
reviewed
Aug 16, 2023
yceballost
previously requested changes
Aug 16, 2023
yceballost
previously approved these changes
Aug 21, 2023
pladaria
previously approved these changes
Aug 22, 2023
marcoskolodny
dismissed stale reviews from pladaria and yceballost
new changes
atabel
reviewed
Aug 23, 2023
yceballost
reviewed
Aug 23, 2023
atabel
approved these changes
Aug 24, 2023
tuentisre
pushed a commit
that referenced
this pull request
Aug 24, 2023
# [14.21.0](v14.20.1...v14.21.0) (2023-08-24) ### Bug Fixes * **Cards:** remove min width from all the cards ([#858](#858)) ([029a6ea](029a6ea)) * **Tabs:** remove extra margin in safari ([#857](#857)) ([be8c2f2](be8c2f2)) ### Features * **FeedbackScreens:** updates in icons, paddings and styling ([#852](#852)) ([4b231e6](4b231e6)) * **Sheet:** new component ([#840](#840)) ([f03ca7c](f03ca7c)) * **utilities:** Remove lodash dependency and replace it with custom functions ([#856](#856)) ([dcaf691](dcaf691))
|
🎉 This PR is included in version 14.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.