-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support different browsers at playwright starts #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#388) * chore: base code for selecting in an array using expresions like a.[key='value'].b * fix: previous unitary tests with the new code * test: add positive unitary tests for the new feature * test: add negative unitary tests * doc: updated methods docstring * doc: updated changelog * fix: flake8 format for unitary testing * fix: flake8 format for dataset module * chore: adapt code to codeclimate bot stupidity * test: add unitary test for invalid list structure
* fix: upgrade Faker version to 25.9 * fix Firefox unittests
…ackground (#397) * bug(QAWTO-212): fix action before the feature with background output with error * fix(QAWTO-212): fix flake8 linter messages * fix(QAWTO-212): move behave import to selected function * docs(QAWTO-212): update changelog
rgonalo
reviewed
Jul 10, 2024
rgonalo
previously approved these changes
Jul 12, 2024
* feat: add initial integration of playwright * avoid error in after_scenario
* chore: include playwright module on setup
rgonalo
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the method to start different browser types with these options.
New options sections can be defined in the properties.cfg:
[PlaywrightBrowserOptions] >> Playwright options for the Browser instance (check here: https://playwright.dev/python/docs/api/class-browsertype#browser-type-launch).
ChromeArguments can be defined in the property "args" or in the old section. In this case, ChromeArguments replaces the defined arguments in args. The same with FirefoxArguments.
FirefoxPreferences works in the same way but the property used is firefox_user_prefs.
ChromeExtensions are added as arguments. Firefox Extensions are not supported in playwright.
[PlaywrightContextOptions] >> Playwright options for the Context instance (check here: https://playwright.dev/python/docs/api/class-browser#browser-new-context)
[PlawrightPageOptions] >> Playwright options for the Page instance (check here: https://playwright.dev/python/docs/api/class-browser#browser-new-page)
It's possible to execute a browser in persistent mode passing the property user_data_dir in PlaywrightContextOptions. In these case, the session will be persisted and used by all the pages. In this case PlawrightBrowserOptions are omitted, only context options are available (check options here: https://playwright.dev/python/docs/api/class-browsertype#browser-type-launch-persistent-context)