Update AGP, Kotlin, Compose, Api level and other dependecies #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamal-alm
commented
Apr 23, 2024
.github/workflows/manual_release.yml
Outdated
Comment on lines
15
to
20
| - name: Set up JDK 17 | ||
| uses: actions/setup-java@v2 | ||
| with: | ||
| distribution: 'temurin' | ||
| java-version: '17' | ||
|
|
There was a problem hiding this comment.
ubuntu-latests uses Java 11 by default, we need to set 17 explicitly
yamal-alm
commented
Apr 23, 2024
yamal-alm
commented
Apr 23, 2024
| @@ -4,12 +4,13 @@ plugins { | |||
| } | |||
|
|
|||
| android { | |||
| compileSdk 33 | |||
| namespace "com.telefonica.tweaks.demo" | |||
There was a problem hiding this comment.
new namespace declaration coming from AGP 8.2.2
yamal-alm
commented
Apr 23, 2024
Comment on lines
-4
to
+7
| compose_compiler_version = '1.4.2' | ||
| kotlin_version = '1.8.10' | ||
| compose_version = '1.3.2' | ||
| compose_material_version = '1.4.0' | ||
| dagger_version = "2.43.2" | ||
| compose_compiler_version = '1.5.12' | ||
| compose_bom_version = '2024.04.01' | ||
| kotlin_version = '1.9.23' | ||
| dagger_version = "2.51.1" |
There was a problem hiding this comment.
ideally we should use a toml catalog, but that is out of scope of this task
yamal-alm
commented
Apr 23, 2024
| dagger_version = "2.43.2" | ||
| compose_compiler_version = '1.5.12' | ||
| compose_bom_version = '2024.04.01' | ||
| kotlin_version = '1.9.23' |
There was a problem hiding this comment.
latest kotlin version
yamal-alm
commented
Apr 23, 2024
| compose_version = '1.3.2' | ||
| compose_material_version = '1.4.0' | ||
| dagger_version = "2.43.2" | ||
| compose_compiler_version = '1.5.12' |
There was a problem hiding this comment.
compose kotlin compiler accoding to this table based on kotlin version
yamal-alm
commented
Apr 23, 2024
Comment on lines
-18
to
+17
| classpath 'com.android.tools.build:gradle:7.4.2' | ||
| classpath 'com.android.tools.build:gradle:8.2.2' |
There was a problem hiding this comment.
agp updated as well
yamal-alm
commented
Apr 23, 2024
library/build.gradle
Outdated
There was a problem hiding this comment.
library module:
- target 34
- java 17
- use latest compose version through BOM
- Use ksp instead of kapt for Dagger
- other dependencies updates
yamal-alm
commented
Apr 23, 2024
build.gradle
Outdated
| @@ -24,6 +23,7 @@ buildscript { | |||
| plugins { | |||
| id("io.gitlab.arturbosch.detekt").version("1.18.1") | |||
| id 'io.github.gradle-nexus.publish-plugin' version '1.3.0' apply false | |||
| id("com.google.devtools.ksp") version "1.9.23-1.0.20" apply false | |||
There was a problem hiding this comment.
using ksp instead of kapt
yamal-alm
requested review from
a team,
pmartinbTEF,
juangardi21 and
jdelga
and removed request for
a team and
juangardi21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
Update AGP, Kotlin, Compose, Api level and other dependencies
🚧 How do we do it?
📘 Documentation changes?
🧪 How can I test this?