Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): 修正 destroyOnClose 属性传递和 dialog 实例生成和返回 #1149

Merged
merged 4 commits into from
Nov 22, 2023
Merged

fix(dialog): 修正 destroyOnClose 属性传递和 dialog 实例生成和返回 #1149

merged 4 commits into from
Nov 22, 2023

Conversation

fennghuang
Copy link
Collaborator

@fennghuang fennghuang commented Nov 6, 2023 •
edited by anlyyao
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix #1148
fix #1151

💡 需求背景和解决方案

📝 更新日志

  • fix(dialog): 修正 destroyOnClose 属性传递和 dialog 实例生成和返回

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023 •
edited
Loading

完成

@fennghuang fennghuang changed the title fix(dialog): 修正 destroyOnClose 属性传递 fix(dialog): 修正 destroyOnClose 属性传递和 dialog 实例生成和返回 Nov 7, 2023
@anlyyao anlyyao merged commit 9c4509a into Tencent:develop Nov 22, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anlyyao anlyyao anlyyao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fennghuang @anlyyao