feat(Guide): add new component #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: +9.92 kB (+2%) Total Size: 437 kB
ℹ️ View Unchanged
|
|
Size Change: +9.92 kB (+2%) Total Size: 437 kB
ℹ️ View Unchanged
|
|
Size Change: +9.91 kB (+2%) Total Size: 437 kB
ℹ️ View Unchanged
|
|
Size Change: +9.91 kB (+2%) Total Size: 437 kB
ℹ️ View Unchanged
|
anlyyao
reviewed
Mar 4, 2024
|
Size Change: +9.91 kB (+2%) Total Size: 437 kB
ℹ️ View Unchanged
|
|
Size Change: +9.91 kB (+2%) Total Size: 437 kB
ℹ️ View Unchanged
|
1.官网上展示默认为中文，麻烦把英文都翻译成中文2.缺少4px的间距
3.圆角大小应为9px
4.圆角大小应为6px
5.button应为extrasmall
|
@Lyan-u 有空在处理一下视觉问题哈， 圆角token可查 _variables.less 文件 |
1.这里不需要圆角
2.圆角大小为6px，标题与文案之间缺少4px的间距
3.圆角大小为6px
4.圆角大小为12px
5.字体大小应为16px
6.字体大小应为18px
@Lyan-u 麻烦留意这里的走查问题～ |
1.这里的icon需要导出视觉稿上的样式，大小为32px*32px
2.margin为16px，font-size为16px
3.margin-top为16px
4.button应使用extrasmall，间距为12px
5.button应调用-light样式
@Lyan-u 麻烦留意这里的走查问题～ |
|
@RADWIMPS426 样式问题已调整 |
|
Size Change: +10 kB (+2%) Total Size: 437 kB
ℹ️ View Unchanged
|
行高为22px
行高为26px
行高为24px
@Lyan-u 麻烦修改这里的行高，其余的没问题了 |
|
Size Change: +10 kB (+2%) Total Size: 437 kB
ℹ️ View Unchanged
|
已调整 |
|
@anlyyao 视觉走查完成～辛苦验收 |
anlyyao
approved these changes
Mar 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
fix #1227
相关 PR
Tencent/tdesign-common#1734
TDesignOteam/tdesign-api#234
💡 需求背景和解决方案
📝 更新日志
feat(Guide): 新增
Guide组件本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单