Add some std::move() calls.

Tencent · Jan 24, 2025 · afabcd3 · afabcd3
1 parent 4d4c481
commit afabcd3
Showing 1 changed file with 13 additions and 12 deletions.
diff --git a/src/gpu/DrawingManager.cpp b/src/gpu/DrawingManager.cpp
@@ -25,10 +25,10 @@
 #include "gpu/tasks/TextureResolveTask.h"
 
 namespace tgfx {
-std::shared_ptr<OpsRenderTask> DrawingManager::addOpsTask(
-    std::shared_ptr<RenderTargetProxy> renderTargetProxy, uint32_t renderFlags) {
-  checkIfResolveNeeded(renderTargetProxy);
-  auto opsTask = std::make_shared<OpsRenderTask>(renderTargetProxy, renderFlags);
+std::shared_ptr<OpsRenderTask> DrawingManager::addOpsTask(std::shared_ptr<RenderTargetProxy> target,
+                                                          uint32_t renderFlags) {
+  checkIfResolveNeeded(target);
+  auto opsTask = std::make_shared<OpsRenderTask>(std::move(target), renderFlags);
   addRenderTask(opsTask);
   activeOpsTask = opsTask;
   return opsTask;
@@ -42,7 +42,8 @@ void DrawingManager::addRuntimeDrawTask(std::shared_ptr<RenderTargetProxy> targe
     return;
   }
   checkIfResolveNeeded(target);
-  auto task = std::make_shared<RuntimeDrawTask>(target, inputs, effect, offset);
+  auto task = std::make_shared<RuntimeDrawTask>(std::move(target), std::move(inputs),
+                                                std::move(effect), offset);
   addRenderTask(std::move(task));
 }
 
@@ -53,15 +54,14 @@ void DrawingManager::addTextureFlattenTask(std::shared_ptr<TextureFlattenTask> f
   flattenTasks.push_back(std::move(flattenTask));
 }
 
-void DrawingManager::addTextureResolveTask(std::shared_ptr<RenderTargetProxy> renderTargetProxy) {
-  auto textureProxy = renderTargetProxy->getTextureProxy();
-  if (textureProxy == nullptr ||
-      (renderTargetProxy->sampleCount() <= 1 && !textureProxy->hasMipmaps())) {
+void DrawingManager::addTextureResolveTask(std::shared_ptr<RenderTargetProxy> target) {
+  auto textureProxy = target->getTextureProxy();
+  if (textureProxy == nullptr || (target->sampleCount() <= 1 && !textureProxy->hasMipmaps())) {
     return;
   }
   // TODO(domchen): Skip resolving if the render target is not in the needResolveTargets set.
-  needResolveTargets.erase(renderTargetProxy);
-  auto task = std::make_shared<TextureResolveTask>(renderTargetProxy);
+  needResolveTargets.erase(target);
+  auto task = std::make_shared<TextureResolveTask>(std::move(target));
   addRenderTask(std::move(task));
 }
 
@@ -71,7 +71,8 @@ void DrawingManager::addRenderTargetCopyTask(std::shared_ptr<RenderTargetProxy>
   if (source == nullptr || dest == nullptr) {
     return;
   }
-  auto task = std::make_shared<RenderTargetCopyTask>(source, dest, srcRect, dstPoint);
+  auto task =
+      std::make_shared<RenderTargetCopyTask>(std::move(source), std::move(dest), srcRect, dstPoint);
   addRenderTask(std::move(task));
 }