feat: 新增内置赋值节点 #82 #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normal-wls
requested changes
Jan 14, 2025
bkflow/pipeline_plugins/components/collections/value_assign/v1_0_0.py
Outdated
Show resolved
Hide resolved
| def plugin_execute(self, data, parent_data): | ||
| runtime = BambooDjangoRuntime() | ||
| upsert_dict = {} | ||
| pipeline_id = self._runtime_attrs["root_pipeline_id"] |
There was a problem hiding this comment.
尽量不从隐藏属性拿数据，看看 parent_data 有没有
bkflow/pipeline_plugins/components/collections/value_assign/v1_0_0.py
Outdated
Show resolved
Hide resolved
normal-wls
requested changes
Jan 14, 2025
| $.atoms.value_assign = [ | ||
| { | ||
| tag_code: "bk_assignment_list", | ||
| type: "datatable", |
normal-wls
requested changes
Jan 14, 2025
| def plugin_execute(self, data, parent_data): | ||
| runtime = BambooDjangoRuntime() | ||
| upsert_dict = {} | ||
| pipeline_id = self._runtime_attrs["root_pipeline_id"] |
| # 处理输入变量与目标变量的类型转换(输入常量时) 如果是相同类型则必然成功 | ||
| try: | ||
| # 尝试将输入转换为目标变量类型 | ||
| input_val = type(context.value)(input_val) |
There was a problem hiding this comment.
确认下，如果变量没有默认值，那么这种方案是不是就有问题。
是否可以考虑如果不做类型校验，评估合理性；确认下这样是不是都可以正常赋值，如果是的话在插件说明中体现
| bound_service = ValueAssignService | ||
| form = settings.STATIC_URL + "components/value_assign/v1_0_0.js" | ||
| version = "v1.0.0" | ||
| desc = "提供内置赋值功能" |
There was a problem hiding this comment.
这里需要补充实现机制，比如目标变量必须存在、类型校验或不校验等
| pipeline_id = self._runtime_attrs["root_pipeline_id"] | ||
| assign_list = data.get_one_of_inputs("bk_assignment_list") | ||
| # 构建目标变量集合 | ||
| target_var_set = {"${{{}}}".format(assign["bk_assgin_target_var"]) for assign in assign_list} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.