-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 支持配置文件恢复 --story=74835198 #2960
feat: 支持配置文件恢复 --story=74835198 #2960
Conversation
51df6ae
to
1ce4a21
Compare
@@ -47,7 +50,8 @@ func (s *Service) CreateConfigItem(ctx context.Context, req *pbds.CreateConfigIt | |||
} | |||
// validate in table config_items | |||
if _, err := s.dao.ConfigItem().GetByUniqueKey(grpcKit, req.ConfigItemAttachment.BizId, | |||
req.ConfigItemAttachment.AppId, req.ConfigItemSpec.Name, req.ConfigItemSpec.Path); err == nil { | |||
req.ConfigItemAttachment.AppId, req.ConfigItemSpec.Name, req.ConfigItemSpec.Path); err == nil && | |||
errors.Is(err, gorm.ErrRecordNotFound) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
err == nil 后面的 && 无效
} | ||
|
||
if commit.ID == releaseCi.CommitID { | ||
return nil, errors.New("It's already the latest version") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里不用判断
1ce4a21
to
2e80254
Compare
} | ||
|
||
commitID := []uint32{} | ||
contextID := []uint32{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该是 contentID
2e80254
to
a234d65
Compare
No description provided.