feat: 共享集群支持查询集群下所有命名空间的release #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adevjoe
suggested changes
Dec 25, 2024
| @@ -102,10 +102,6 @@ func (l *ListReleaseV1Action) list() (*helmmanager.ReleaseListData, error) { | |||
| dbReleases = append(dbReleases, item.Transfer2Proto()) | |||
| } | |||
|
|
|||
| if cluster.IsShared && len(option.Namespace) == 0 { | |||
There was a problem hiding this comment.
要先获取命名空间列表，然后根据列表并发去获取 release
LidolLxf
force-pushed
the
feat_share_release
branch
from
f83a591 to
b271799
Compare
adevjoe
suggested changes
Jan 14, 2025
| if err != nil { | ||
| return nil, err | ||
| } | ||
| p, err := cli.Namespace.ListNamespaces(context.Background(), &bcsproject.ListNamespacesRequest{ |
adevjoe
approved these changes
Jan 14, 2025
ifooth
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: 共享集群支持查询集群下所有命名空间的release