feature: 对接蓝鲸消息通知中心 #2659 #2672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
定义接口，Mock数据
修复对2xx状态码的处理
调整异常http状态码描述
支持offset与limit参数； ESB响应成功判断支持无code仅有result字段。
wangyu096
requested changes
Dec 19, 2023
| import java.util.concurrent.ThreadPoolExecutor; | ||
|
|
||
| /** | ||
| * 进程启动时立即执行一次无效主机清理 |
| @@ -38,6 +38,12 @@ public class LocaleUtils { | |||
| public static final String LANG_ZH = "zh"; | |||
| public static final String LANG_EN = "en"; | |||
| public static final String LANG_EN_US = "en_US"; | |||
|
|
|||
| public static final String BK_LANG_ZH = "zh"; | |||
There was a problem hiding this comment.
BK_LANG_XX 跟 LANG_XX 的区别是啥？这里放在一起容易混淆。
建议如果这两种类型的 LANG 是用在不同的地方，是否可以放到不同的类里边加以区分？或者加上注释
| @@ -126,6 +127,21 @@ Default job logback configuration provided for import | |||
| </encoder> | |||
| </appender> | |||
|
|
|||
| <!-- BK-NOTICE 日志 --> | |||
| <appender name="notice-appender" class="ch.qos.logback.core.rolling.RollingFileAppender"> | |||
There was a problem hiding this comment.
这个通知模块只有 job-manage 涉及，放在 job-manage 的 logback 配置下可能更合适？放在公共的配置，每个微服务下都会生成 notice.log
|
job-assemble 没有处理，比如配置 |
|
对接消息中心是否是强依赖？如果没有消息中心的话，服务是否能够正常运行？这点需要确认下 |
非强依赖，已在jobv3环境验证，并补充了支持配置是否对接消息中心与自动探测消息中心可用性的机制。 |
处理review意见
只新增了公共配置项，job-assemble也能引用到，没有单独微服务的配置，因此无需处理。 |
处理review意见
处理review意见，支持关闭消息通知中心对接，消除错误日志
支持自动探测消息通知中心状态用于决定是否自动对接
支持自动探测消息通知中心状态用于决定是否自动对接
补充VALUES_LOG.md
记录注册状态到DB
wangyu096
requested changes
Dec 20, 2023
| @@ -37,6 +37,8 @@ public class BkApiGatewayProperties { | |||
|
|
|||
| private GseApiGwConfig gse; | |||
|
|
|||
| private GseApiGwConfig bkNotice; | |||
There was a problem hiding this comment.
GseApiGwConfig 与 bkNotice 不匹配。可能需要改下 GseApiGwConfig 的类名，更加通用一些
| } | ||
| } | ||
| // 将注册结果写入DB中 | ||
| int affectedNum = globalSettingDAO.upsertGlobalSetting(buildRegisterResult(registerSuccess)); |
There was a problem hiding this comment.
多个实例一起执行可能有并发问题，导致注册结果被覆盖
处理review意见
wangyu096
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.