perf: 优化插入MySQL时脚本参数过长的报错信息，展示具体错误 #3374 #3395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonwan
reviewed
Jan 21, 2025
...backend/commons/common-i18n/src/main/resources/i18n/validation/ValidationMessages.properties
Show resolved
Hide resolved
jsonwan
reviewed
Jan 21, 2025
src/backend/commons/common-utils/src/main/java/com/tencent/bk/job/common/util/Base64Util.java
Outdated
Show resolved
Hide resolved
jsonwan
reviewed
Jan 21, 2025
...c/main/java/com/tencent/bk/job/execute/model/esb/v2/request/EsbFastExecuteScriptRequest.java
Outdated
Show resolved
Hide resolved
jsonwan
reviewed
Jan 21, 2025
...c/main/java/com/tencent/bk/job/execute/model/esb/v2/request/EsbFastExecuteScriptRequest.java
Outdated
Show resolved
Hide resolved
jsonwan
reviewed
Jan 21, 2025
...m/tencent/bk/job/execute/model/esb/v3/bkci/plugin/EsbBkCIPluginFastExecuteScriptRequest.java
Outdated
Show resolved
Hide resolved
jsonwan
reviewed
Jan 21, 2025
...m/tencent/bk/job/execute/model/esb/v3/bkci/plugin/EsbBkCIPluginFastExecuteScriptRequest.java
Outdated
Show resolved
Hide resolved
jsonwan
reviewed
Jan 21, 2025
...main/java/com/tencent/bk/job/execute/model/esb/v3/request/EsbFastExecuteScriptV3Request.java
Outdated
Show resolved
Hide resolved
jsonwan
reviewed
Jan 21, 2025
...main/java/com/tencent/bk/job/execute/model/esb/v3/request/EsbFastExecuteScriptV3Request.java
Outdated
Show resolved
Hide resolved
jsonwan
reviewed
Jan 21, 2025
.../src/main/java/com/tencent/bk/job/execute/model/web/request/WebFastExecuteScriptRequest.java
Outdated
Show resolved
Hide resolved
jsonwan
reviewed
Jan 22, 2025
|
|
||
| @Override | ||
| public String toString() { | ||
| return value + "(" + maximumLength + ")"; |
There was a problem hiding this comment.
这个对于用户来说依然不够友好，建议修改为 255 Bytes/ 64K Bytes / 16M Bytes / 4G Bytes 这种形式，项目中也有现成的转换工具类可用，可以多站在用户角度去思考想要得到怎样的数据。
jsonwan
reviewed
Jan 22, 2025
| void testCalcOriginBytesLength() { | ||
| for (int i = 0; i < 100; i++) { | ||
| String originStr = genRandomString(); | ||
| assertCal(originStr); |
jsonwan
reviewed
Jan 22, 2025
| private void assertCal(String originStr) { | ||
|
|
||
| String encodedStr = Base64Util.encodeContentToStr(originStr); | ||
| int calLengthByUtil = Base64Util.calcOriginBytesLength(encodedStr); |
|
保存作业模板的场景也需要处理下。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web/esb 快速执行脚本时，使用自定义校验器对scriptParam和scriptContent进行长度校验